Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programming exercises: Update template dependencies for java exercises #7050

Merged
merged 13 commits into from
Aug 12, 2023

Conversation

Strohgelaender
Copy link
Contributor

@Strohgelaender Strohgelaender commented Aug 7, 2023

Checklist

General

Motivation and Context

Updates the standard dependency versions in the Java PE templates to their newest versions.

Description

Also enhances the existing TemplateIntegrationTest to check if the tests can be executed when the testwise coverage analysis is enabled. The maven testwise coverage feature was broken in its current form (the dependency got renamed), this new test can now catch such issues.

Related docker PR: ls1intum/artemis-maven-docker#134

Steps for Testing

Create a new programming exercise and check that everything still works.

Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

@github-actions github-actions bot added the tests label Aug 8, 2023
@Strohgelaender Strohgelaender marked this pull request as ready for review August 8, 2023 13:25
@Strohgelaender Strohgelaender requested a review from a team as a code owner August 8, 2023 13:25
@Strohgelaender Strohgelaender changed the title Programming exercises: Update default java dependencies Programming exercises: Update template dependencies for java exercises Aug 8, 2023
@github-actions github-actions bot added the config-change Pull requests that change the config in a way that they require a deployment via Ansible. label Aug 11, 2023
Copy link
Contributor

@tobias-lippert tobias-lippert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in testing session.
Everything concerning PE worked.
Code looks good.

Copy link
Contributor

@aplr aplr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in testing session, changes don't seem to break anything

Copy link
Contributor

@reschandreas reschandreas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in testing session. Looks good, the test still ran through 👍🏻

Copy link
Contributor

@nityanandaz nityanandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks neat

@sleiss sleiss self-requested a review August 11, 2023 15:57
Copy link
Contributor

@sleiss sleiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested during the testing session, worked as expected.

@krusche krusche added this to the 6.4.0 milestone Aug 12, 2023
@krusche krusche merged commit 2588dbd into develop Aug 12, 2023
32 of 34 checks passed
@krusche krusche deleted the chore/pe-dependency-updates branch August 12, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config-change Pull requests that change the config in a way that they require a deployment via Ansible. ready to merge tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants