-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Programming exercises
: Update template dependencies for java exercises
#7050
Conversation
Programming exercises
: Update default java dependenciesProgramming exercises
: Update template dependencies for java exercises
…ore/pe-dependency-updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in testing session.
Everything concerning PE worked.
Code looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in testing session, changes don't seem to break anything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in testing session. Looks good, the test still ran through 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks neat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested during the testing session, worked as expected.
Checklist
General
Motivation and Context
Updates the standard dependency versions in the Java PE templates to their newest versions.
Description
Also enhances the existing TemplateIntegrationTest to check if the tests can be executed when the testwise coverage analysis is enabled. The maven testwise coverage feature was broken in its current form (the dependency got renamed), this new test can now catch such issues.
Related docker PR: ls1intum/artemis-maven-docker#134
Steps for Testing
Create a new programming exercise and check that everything still works.
Review Progress
Code Review
Manual Tests