Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exam mode: Visualize student submissions in exam timeline #6882

Merged
merged 118 commits into from
Oct 21, 2023

fix import

6a1149e
Select commit
Loading
Failed to load commit list.
Merged

Exam mode: Visualize student submissions in exam timeline #6882

fix import
6a1149e
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codacy Production / Codacy Static Code Analysis required action Oct 18, 2023 in 0s

4 new issues (0 max.) of at least minor severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 4
           

Coverage increased per file
===========================
+ src/main/java/de/tum/in/www1/artemis/domain/hestia/ProgrammingExerciseGitDiffEntry.java  4.348
+ src/main/java/de/tum/in/www1/artemis/service/hestia/ProgrammingExerciseGitDiffReportService.java  2.393
+ src/main/java/de/tum/in/www1/artemis/repository/SubmissionRepository.java  0.263
+ src/main/java/de/tum/in/www1/artemis/service/connectors/GitService.java  1.022
+ src/main/java/de/tum/in/www1/artemis/exception/GitException.java  25.0
+ src/main/java/de/tum/in/www1/artemis/web/rest/ProgrammingExerciseParticipationResource.java  1.389
+ src/main/java/de/tum/in/www1/artemis/web/rest/repository/RepositoryProgrammingExerciseParticipationResource.java  2.243
+ src/main/java/de/tum/in/www1/artemis/web/rest/SubmissionResource.java  0.853
+ src/main/java/de/tum/in/www1/artemis/service/programming/ProgrammingExerciseParticipationService.java  0.455
         

Coverage decreased per file
===========================
- src/main/java/de/tum/in/www1/artemis/web/rest/hestia/ProgrammingExerciseGitDiffReportResource.java  -6.897
         

Complexity increasing per file
==============================
- src/test/javascript/spec/component/programming-exercise/cached-repository-files-service.service.spec.ts  1
- src/main/webapp/app/exercises/programming/manage/services/cached-repository-files.service.ts  1
- src/main/webapp/app/exercises/programming/shared/commits-info/commits-info.component.ts  3
- src/main/webapp/app/exam/manage/student-exams/student-exam-timeline/programming-exam-diff/programming-exercise-exam-diff.component.ts  3
- src/test/javascript/spec/component/exam/manage/programming-exam-diff.component.spec.ts  1
- src/test/javascript/spec/component/shared/commits-info.component.spec.ts  1
- src/test/javascript/spec/component/hestia/git-diff-report/git-diff-modal.component.spec.ts  1
- src/test/javascript/spec/service/submission-version.service.spec.ts  1
- src/main/webapp/app/exercises/shared/submission-version/submission-version.service.ts  1
- src/test/javascript/spec/component/exam/manage/student-exams/student-exam-timeline.component.spec.ts  7
- src/main/webapp/app/exam/manage/student-exams/student-exam-timeline/student-exam-timeline.component.ts  8
- src/main/webapp/app/exercises/programming/hestia/git-diff-report/git-diff-report-modal.component.ts  2
- src/main/java/de/tum/in/www1/artemis/web/rest/hestia/ProgrammingExerciseGitDiffReportResource.java  3
- src/main/webapp/app/exam/participate/exercises/file-upload/file-upload-exam-submission.component.ts  1
- src/main/webapp/app/exam/participate/exam-navigation-bar/exam-navigation-bar.component.ts  2
         

See the complete overview on Codacy

Annotations

Check notice on line 26 in src/main/webapp/app/exam/manage/student-exams/student-exam-detail.component.scss

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/main/webapp/app/exam/manage/student-exams/student-exam-detail.component.scss#L26

Expected empty line before rule (rule-empty-line-before)

Check notice on line 197 in src/test/java/de/tum/in/www1/artemis/util/GitUtilService.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/test/java/de/tum/in/www1/artemis/util/GitUtilService.java#L197

Missing a Javadoc comment.

Check notice on line 202 in src/test/java/de/tum/in/www1/artemis/util/HestiaUtilTestService.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/test/java/de/tum/in/www1/artemis/util/HestiaUtilTestService.java#L202

Missing a Javadoc comment.

Check notice on line 3 in src/test/javascript/spec/helpers/stubs/ngx-slider-stub.component.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/test/javascript/spec/helpers/stubs/ngx-slider-stub.component.ts#L3

The selector should start with one of these prefixes: "jhi" (https://angular.io/guide/styleguide#style-02-07)