Programming Exercises: Align title and buttons for participation page

[laxerhd]

Opening this PR from a branch in the main repository to enable test server deployment, as it wasn't possible with the previous PR from a forked repository (see #9983)

Checklist

General

• I tested all changes and their related features with all corresponding user types on a test server.
• This is a small issue that I tested locally and was confirmed by another developer on a test server.
• I chose a title conforming to the naming conventions for pull requests.

Client

• Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
• I added multiple screenshots/screencasts of my UI changes.

Motivation and Context

Very optional changes, but it was a little offputting that the buttons weren't actually centered with anything.
(Another solution could be to center them with the original div structure to place them in the middle of the title and filters.)
I simply find these changes more aesthetic.
Closes #9967.

Description

• Adjusted div structure (swapped buttons and filters) and classes to achieve centering of buttons
• Ensured filters remain in a separate row below the title and buttons
• Refactored layout with no impact on functionality

Steps for Testing

Prerequisites:

• 1 Instructor
• 1 Exercise

1. Go to an exercise as an instructor
2. Click on Instructor actions -> Participations
3. Take a look at the title and buttons centered

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.

Review Progress

Performance Review

• I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance even for very large courses with more than 2000 students.
• I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance even for very large courses with more than 2000 students.

Code Review

• Code Review 1
• Code Review 2

Manual Tests

• Test 1
• Test 2

Exam Mode Test

• Test 1
• Test 2

Performance Tests

• Test 1
• Test 2

Screenshots

Before:

After:

Summary by CodeRabbit

• Style
  • Improved layout and organization of the participation component
  • Restructured HTML layout using flexbox for better alignment
  • Simplified header styling
  • Reorganized radio button filter section

[coderabbitai]

Walkthrough

The pull request modifies the participation.component.html file, focusing on restructuring the HTML layout and improving the visual organization of the exercise participations page. The changes involve creating a more flexible and aligned layout using flexbox, repositioning elements like the header, radio button filters, and action buttons while maintaining the existing conditional rendering logic.

Changes

File	Change Summary
src/main/webapp/app/exercises/shared/participation/participation.component.html	Restructured HTML layout with flexbox, simplified header, repositioned radio button filters, and adjusted positioning of action buttons

Assessment against linked issues

Objective	Addressed	Explanation
Align title and buttons on exercise participations page [#9967]	✅

Suggested Labels

client, small, ready for review

Suggested Reviewers

• krusche
• Feras797
• DominikRemo
• coolchock

Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

src/main/webapp/app/exercises/shared/participation/participation.component.html (2)

32-51: Consider adding ARIA labels for better accessibility

While the layout is well-structured, consider enhancing accessibility by adding aria-label attributes to the radio inputs.

-            <input type="radio" [ngModel]="participationCriteria.filterProp" (click)="updateParticipationFilter(FilterProp.ALL)" [value]="FilterProp.ALL" />
+            <input type="radio" [ngModel]="participationCriteria.filterProp" (click)="updateParticipationFilter(FilterProp.ALL)" [value]="FilterProp.ALL" 
+                   aria-label="{{ 'artemisApp.exercise.showAll' | translate }}" />

---

Line range hint 52-400: Consider extracting presentation-related functionality

The data table section contains complex presentation score logic that could be extracted into a separate component for better maintainability and reusability.

Consider creating a new component like presentation-score.component to handle the presentation-related columns and buttons, which would:

• Reduce complexity in the main template
• Improve maintainability
• Make the presentation feature more modular and reusable

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1798b25 and 9442db2.

📒 Files selected for processing (1)

• src/main/webapp/app/exercises/shared/participation/participation.component.html (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

src/main/webapp/app/exercises/shared/participation/participation.component.html (1)

Pattern src/main/webapp/**/*.html: @if and @for are new and valid Angular syntax replacing *ngIf and *ngFor. They should always be used over the old style.

⏰ Context from checks skipped due to timeout of 90000ms (10)

• GitHub Check: client-compilation
• GitHub Check: client-tests-selected
• GitHub Check: client-style
• GitHub Check: server-tests
• GitHub Check: server-style
• GitHub Check: client-tests
• GitHub Check: Build and Push Docker Image
• GitHub Check: Build .war artifact
• GitHub Check: Analyse
• GitHub Check: Codacy Static Code Analysis

🔇 Additional comments (2)

src/main/webapp/app/exercises/shared/participation/participation.component.html (2)

2-31: Well-structured layout implementation!

The new flex layout with justify-content-between effectively centers and aligns the title and buttons. Good use of the new @if syntax for conditional rendering.

---

Line range hint 1-400: Implementation successfully meets PR objectives

The changes effectively improve the layout by:

• Centering the title and buttons using flex layout
• Maintaining clear separation of filters
• Preserving all existing functionality

[github-actions]

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.