Development: Improve client config

ls1intum · Jan 2, 2025 · b26821c · b26821c
1 parent 49a91a4
commit b26821c
Show file tree

Hide file tree

Showing 10 changed files with 249 additions and 22 deletions.
diff --git a/LICENSE b/LICENSE
@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2024 TUM Applied Education Technologies
+Copyright (c) 2025 TUM Applied Education Technologies
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

diff --git a/angular.json b/angular.json
@@ -226,7 +226,7 @@
     "packageManager": "npm",
     "cache": {
       "enabled": true,
-      "path": ".cache",
+      "path": "./build/angular/",
       "environment": "all"
     },
     "schematicCollections": [

diff --git a/docs/conf.py b/docs/conf.py
@@ -18,7 +18,7 @@
 # -- Project information -----------------------------------------------------
 
 project = 'Artemis'
-copyright = '2024, Applied Education Technologies, Technical University of Munich'
+copyright = '2025, Applied Education Technologies, Technical University of Munich'
 author = 'Applied Education Technologies, Technical University of Munich'
 
 

diff --git a/gradle/test.gradle b/gradle/test.gradle
@@ -57,7 +57,8 @@ test {
         useJUnitPlatform()
         exclude "**/*IT*", "**/*IntTest*"
     }
-
+    testClassesDirs = testing.suites.test.sources.output.classesDirs
+    classpath = testing.suites.test.sources.runtimeClasspath
     testLogging {
         events "FAILED", "SKIPPED"
     }

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -165,6 +165,7 @@
         "sass": "1.83.0",
         "ts-jest": "29.2.5",
         "typescript": "5.5.4",
+        "typescript-eslint": "8.18.2",
         "vite-tsconfig-paths": "5.1.4",
         "vitest": "2.1.8",
         "weak-napi": "2.0.2"

diff --git a/...ain/webapp/app/exercises/quiz/manage/apollon-diagrams/apollon-diagram-detail.component.ts b/...ain/webapp/app/exercises/quiz/manage/apollon-diagrams/apollon-diagram-detail.component.ts
@@ -27,10 +27,8 @@ export class ApollonDiagramDetailComponent implements OnInit, OnDestroy {
     @ViewChild('editorContainer', { static: false }) editorContainer: ElementRef;
     @ViewChild('titleField') titleField?: NgModel;
 
-    @Input()
-    private courseId: number;
-    @Input()
-    private apollonDiagramId: number;
+    @Input() courseId: number;
+    @Input() apollonDiagramId: number;
 
     @Output() closeEdit = new EventEmitter<DragAndDropQuestion | undefined>();
     @Output() closeModal = new EventEmitter();

diff --git a/...ogs/conversation-add-users-dialog/add-users-form/conversation-add-users-form.component.ts b/...ogs/conversation-add-users-dialog/add-users-form/conversation-add-users-form.component.ts
@@ -19,13 +19,12 @@ export interface AddUsersFormData {
 })
 export class ConversationAddUsersFormComponent implements OnInit, OnChanges {
     @Output() formSubmitted: EventEmitter<AddUsersFormData> = new EventEmitter<AddUsersFormData>();
+
     @Input() courseId: number;
     @Input() maxSelectable?: number = undefined;
+    @Input() activeConversation: ConversationDTO;
 
-    @Input()
-    activeConversation: ConversationDTO;
-
-    protected readonly isLoading = input<boolean>(false);
+    isLoading = input<boolean>(false);
 
     form: FormGroup;
 

diff --git a/src/main/webapp/app/overview/course-lectures/lecture-unit/lecture-unit.component.ts b/src/main/webapp/app/overview/course-lectures/lecture-unit/lecture-unit.component.ts
@@ -16,21 +16,20 @@ export class LectureUnitComponent {
     protected faSquareCheck = faSquareCheck;
     protected faSquare = faSquare;
 
-    readonly lectureUnit = input.required<LectureUnit>();
-    protected readonly icon = input.required<IconDefinition>();
+    lectureUnit = input.required<LectureUnit>();
+    icon = input.required<IconDefinition>();
 
-    readonly showViewIsolatedButton = input<boolean>(false);
-    readonly viewIsolatedButtonLabel = input<string>('artemisApp.textUnit.isolated');
-    readonly viewIsolatedButtonIcon = input<IconDefinition>(faExternalLinkAlt);
-    readonly onShowIsolated = output<void>();
+    showViewIsolatedButton = input<boolean>(false);
+    viewIsolatedButtonLabel = input<string>('artemisApp.textUnit.isolated');
+    viewIsolatedButtonIcon = input<IconDefinition>(faExternalLinkAlt);
+    isPresentationMode = input.required<boolean>();
 
-    readonly isCollapsed = signal<boolean>(true);
+    readonly onShowIsolated = output<void>();
     readonly onCollapse = output<boolean>();
-
-    readonly isPresentationMode = input.required<boolean>();
-
     readonly onCompletion = output<boolean>();
 
+    readonly isCollapsed = signal<boolean>(true);
+
     readonly isVisibleToStudents = computed(() => this.lectureUnit().visibleToStudents);
 
     toggleCompletion(event: Event) {

diff --git a/tsconfig.json b/tsconfig.json
@@ -33,6 +33,8 @@
     "angularCompilerOptions": {
         "genDir": "build/resources/main/aot",
         "skipMetadataEmit": true,
+        "strictInjectionParameters": true,
+        "strictInputAccessModifiers": true,
         "fullTemplateTypeCheck": true,
         "strictTemplates": true,
         "preserveWhitespaces": true,