added suggestions

ls1intum · Oct 12, 2024 · 68c40fc · 68c40fc
1 parent 1734d3d
commit 68c40fc
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/src/main/webapp/app/shared/user-settings/ssh-settings/ssh-user-settings.component.html b/src/main/webapp/app/shared/user-settings/ssh-settings/ssh-user-settings.component.html
@@ -76,7 +76,7 @@ <h4 jhiTranslate="artemisApp.userSettings.sshSettingsPage.keysTablePageTitle"></
                                                 deleteQuestion="artemisApp.userSettings.sshSettingsPage.deleteSshKeyQuestion"
                                                 [dialogError]="dialogError$"
                                             >
-                                                <div jhiTranslate="artemisApp.userSettings.sshSettingsPage.deleteSshKey" class="ms-2">Delete</div>
+                                                <span jhiTranslate="artemisApp.userSettings.sshSettingsPage.deleteSshKey" class="ms-2">Delete</span>
                                             </button>
                                         </div>
                                     </div>

diff --git a/src/main/webapp/app/shared/user-settings/ssh-settings/ssh-user-settings.component.ts b/src/main/webapp/app/shared/user-settings/ssh-settings/ssh-user-settings.component.ts
@@ -105,10 +105,10 @@ export class SshUserSettingsComponent implements OnInit {
     protected readonly ButtonType = ButtonType;
     protected readonly ButtonSize = ButtonSize;
 
-    setMessageBasedOnOS(os: string): void {
+    private setMessageBasedOnOS(os: string): void {
         switch (os) {
             case 'Windows':
-                this.copyInstructions = 'clip < ~/.ssh/id_ed25519.pub | clip';
+                this.copyInstructions = 'cat ~/.ssh/id_ed25519.pub | clip';
                 break;
             case 'MacOS':
                 this.copyInstructions = 'pbcopy < ~/.ssh/id_ed25519.pub';
@@ -120,7 +120,7 @@ export class SshUserSettingsComponent implements OnInit {
                 this.copyInstructions = 'termux-clipboard-set < ~/.ssh/id_ed25519.pub';
                 break;
             default:
-                this.copyInstructions = 'Ctrl + c';
+                this.copyInstructions = 'Ctrl + C';
         }
     }
 }
diff --git a/src/main/webapp/app/shared/util/os-detector.util.ts b/src/main/webapp/app/shared/util/os-detector.util.ts
@@ -5,10 +5,10 @@ export function getOS(): string {
         return 'Windows';
     } else if (userAgent.indexOf('Mac') !== -1) {
         return 'MacOS';
-    } else if (userAgent.indexOf('Linux') !== -1) {
-        return 'Linux';
     } else if (/Android/.test(userAgent)) {
         return 'Android';
+    } else if (userAgent.indexOf('Linux') !== -1) {
+        return 'Linux';
     } else if (/iPhone|iPad|iPod/.test(userAgent)) {
         return 'iOS';
     } else {

diff --git a/src/main/webapp/i18n/de/userSettings.json b/src/main/webapp/i18n/de/userSettings.json
@@ -30,7 +30,7 @@
                 "editExistingSshKey": "Bearbeiten",
                 "viewExistingSshKey": "Ansehen",
                 "addNewSshKey": "SSH Schlüssel hinzufügen",
-                "sshKeyDetails": "SSH Key Informationen",
+                "sshKeyDetails": "SSH Schlüssel Informationen",
                 "deleteSshKey": "Löschen",
                 "sshKeyDisplayedInformation": "Das ist dein aktuell konfigurierter SSH-Schlüssel:",
                 "key": "Schlüssel",

diff --git a/src/main/webapp/i18n/en/userSettings.json b/src/main/webapp/i18n/en/userSettings.json
@@ -35,7 +35,7 @@
                 "sshKeyDisplayedInformation": "This is your currently configured SSH key:",
                 "key": "Key",
                 "noKeysHaveBeenAdded": "No SSH keys have been added",
-                "whatToUseSSHForInfo": "Use SSH keys to connect simply and safely to repositories.",
+                "whatToUseSSHForInfo": "Use SSH keys to connect simply and securely to repositories.",
                 "learnMore": "Learn more about SSH keys",
                 "alreadyHaveKey": "Already have a key? Copy your key to the clipboard:",
                 "back": "Back",