remove redundant null checks

ls1intum · Oct 28, 2023 · 2c85bc7 · 2c85bc7
1 parent 4bf9968
commit 2c85bc7
Showing 1 changed file with 0 additions and 20 deletions.
diff --git a/src/main/java/de/tum/in/www1/artemis/web/rest/FileResource.java b/src/main/java/de/tum/in/www1/artemis/web/rest/FileResource.java
@@ -252,10 +252,6 @@ public ResponseEntity<byte[]> getFileUploadSubmission(@PathVariable Long exercis
             throw new AccessForbiddenException();
         }
 
-        if (submission.getFilePath() == null) {
-            throw new EntityNotFoundException("Submission " + submissionId + " has no file");
-        }
-
         return buildFileResponse(getActualPathFromPublicPathString(submission.getFilePath()), false);
     }
 
@@ -301,10 +297,6 @@ public ResponseEntity<byte[]> getUserSignature(@PathVariable Long examUserId) {
         ExamUser examUser = examUserRepository.findWithExamById(examUserId).orElseThrow();
         authorizationCheckService.checkHasAtLeastRoleInCourseElseThrow(Role.INSTRUCTOR, examUser.getExam().getCourse(), null);
 
-        if (examUser.getSigningImagePath() == null) {
-            throw new EntityNotFoundException("Exam user " + examUserId + " has no signature file");
-        }
-
         return buildFileResponse(getActualPathFromPublicPathString(examUser.getSigningImagePath()), false);
     }
 
@@ -321,10 +313,6 @@ public ResponseEntity<byte[]> getExamUserImage(@PathVariable Long examUserId) {
         ExamUser examUser = examUserRepository.findWithExamById(examUserId).orElseThrow();
         authorizationCheckService.checkHasAtLeastRoleInCourseElseThrow(Role.INSTRUCTOR, examUser.getExam().getCourse(), null);
 
-        if (examUser.getStudentImagePath() == null) {
-            throw new EntityNotFoundException("Exam user " + examUserId + " has no image file");
-        }
-
         return buildFileResponse(getActualPathFromPublicPathString(examUser.getStudentImagePath()), true);
     }
 
@@ -352,10 +340,6 @@ public ResponseEntity<byte[]> getLectureAttachment(@PathVariable Long lectureId,
         // check if the user is authorized to access the requested attachment unit
         checkAttachmentAuthorizationOrThrow(course, attachment);
 
-        if (attachment.getLink() == null) {
-            throw new EntityNotFoundException("Attachment " + filename + " has no file");
-        }
-
         return buildFileResponse(getActualPathFromPublicPathString(attachment.getLink()), false);
     }
 
@@ -413,10 +397,6 @@ public ResponseEntity<byte[]> getAttachmentUnitAttachment(@PathVariable Long att
         // check if the user is authorized to access the requested attachment unit
         checkAttachmentAuthorizationOrThrow(course, attachment);
 
-        if (attachment.getLink() == null) {
-            throw new EntityNotFoundException("Attachment " + attachmentUnitId + " has no file");
-        }
-
         return buildFileResponse(getActualPathFromPublicPathString(attachment.getLink()), false);
     }