Rename methods for clarity

ls1intum · Oct 21, 2024 · 22488d3 · 22488d3
1 parent 2e3b924
commit 22488d3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/...in/java/de/tum/cit/aet/artemis/iris/service/pyris/PyrisProgrammingExerciseDTOService.java b/...in/java/de/tum/cit/aet/artemis/iris/service/pyris/PyrisProgrammingExerciseDTOService.java
@@ -57,7 +57,7 @@ public PyrisProgrammingExerciseDTOService(GitService gitService, RepositoryServi
      * @param exercise the programming exercise to convert
      * @return the converted PyrisProgrammingExerciseDTO
      */
-    public PyrisProgrammingExerciseDTO convert(ProgrammingExercise exercise) {
+    public PyrisProgrammingExerciseDTO convertExercise(ProgrammingExercise exercise) {
         var templateRepositoryContents = getFilteredRepositoryContents(exercise.getTemplateParticipation());
         var solutionRepositoryContents = getFilteredRepositoryContents(exercise.getSolutionParticipation());
         Optional<Repository> testRepo = Optional.empty();
@@ -91,7 +91,7 @@ public PyrisProgrammingExerciseDTO convert(ProgrammingExercise exercise) {
      * @param submission the students submission
      * @return the converted PyrisSubmissionDTO
      */
-    public PyrisSubmissionDTO convert(ProgrammingSubmission submission) {
+    public PyrisSubmissionDTO convertSubmission(ProgrammingSubmission submission) {
         // @formatter:off
         var buildLogEntries = submission.getBuildLogEntries()
                 .stream()

diff --git a/...main/java/de/tum/cit/aet/artemis/iris/service/session/IrisExerciseChatSessionService.java b/...main/java/de/tum/cit/aet/artemis/iris/service/session/IrisExerciseChatSessionService.java
@@ -153,8 +153,8 @@ public void requestAndHandleResponse(IrisExerciseChatSession irisSession) {
 
         String variant = irisSettingsService.getCombinedIrisSettingsFor(session.getExercise(), false).irisChatSettings().selectedVariant();
         var exercise = programmingExerciseRepository.findByIdWithTemplateAndSolutionParticipationElseThrow(session.getExercise().getId());
-        var latestSubmissionDTO = getLatestSubmissionIfExists(exercise, session.getUser()).map(pyrisProgrammingExerciseDTOService::convert).orElse(null);
-        var exerciseDTO = pyrisProgrammingExerciseDTOService.convert(exercise);
+        var latestSubmissionDTO = getLatestSubmissionIfExists(exercise, session.getUser()).map(pyrisProgrammingExerciseDTOService::convertSubmission).orElse(null);
+        var exerciseDTO = pyrisProgrammingExerciseDTOService.convertExercise(exercise);
         var course = exercise.getCourseViaExerciseGroupOrCourseMember();
         var courseDTO = PyrisCourseDTO.from(course);
         var conversationDTO = session.getMessages().stream().map(PyrisMessageDTO::from).toList();