Development: Remove the unused Ace code editor component (#8832)

ls1intum · Jul 2, 2024 · 0059ca7 · 0059ca7
1 parent d0c3b8d
commit 0059ca7
Show file tree

Hide file tree

Showing 28 changed files with 65 additions and 1,467 deletions.
diff --git a/src/main/webapp/app/entities/build-log.model.ts b/src/main/webapp/app/entities/build-log.model.ts
@@ -1,5 +1,5 @@
 import { safeUnescape } from 'app/shared/util/security.util';
-import { Annotation } from 'app/exercises/programming/shared/code-editor/ace/code-editor-ace.component';
+import { Annotation } from 'app/exercises/programming/shared/code-editor/monaco/code-editor-monaco.component';
 import { ProgrammingLanguage, ProjectType } from 'app/entities/programming-exercise.model';
 
 export enum BuildLogType {

diff --git a/...app/app/exam/participate/exercises/programming/programming-exam-submission.component.html b/...app/app/exam/participate/exercises/programming/programming-exam-submission.component.html
@@ -25,7 +25,6 @@ <h4 class="mb-0 me-1">Online Code Editor</h4>
             }
         </div>
         <jhi-code-editor-container
-            [useMonacoEditor]="true"
             [editable]="!repositoryIsLocked"
             [participation]="studentParticipation"
             [showEditorInstructions]="showEditorInstructions"

diff --git a/...pp/app/exercises/programming/assess/code-editor-tutor-assessment-container.component.html b/...pp/app/exercises/programming/assess/code-editor-tutor-assessment-container.component.html
@@ -60,7 +60,6 @@
         >
             @if (!loadingParticipation && !participationCouldNotBeFetched) {
                 <jhi-code-editor-container
-                    [useMonacoEditor]="true"
                     [editable]="false"
                     [participation]="participation"
                     [feedbackSuggestions]="feedbackSuggestions"

diff --git a/...bapp/app/exercises/programming/assess/code-editor-tutor-assessment-container.component.ts b/...bapp/app/exercises/programming/assess/code-editor-tutor-assessment-container.component.ts
@@ -341,7 +341,8 @@ export class CodeEditorTutorAssessmentContainerComponent implements OnInit, OnDe
     }
 
     private highlightLines(firstLine: number, lastLine: number) {
-        this.codeEditorContainer.highlightLines(firstLine, lastLine);
+        // We add 1 to make the lines 1-based.
+        this.codeEditorContainer.highlightLines(firstLine + 1, lastLine + 1);
     }
 
     /**
@@ -541,7 +542,7 @@ export class CodeEditorTutorAssessmentContainerComponent implements OnInit, OnDe
 
     /**
      * Remove a feedback suggestion because it was accepted or discarded.
-     * The actual feedback creation when accepting happens in code-editor-ace-component/unreferenced-feedback because they have full control over the suggestion cards.
+     * The actual feedback creation when accepting happens in code-editor-monaco-component/unreferenced-feedback because they have full control over the suggestion cards.
      * @param feedback Feedback suggestion that is removed
      */
     removeSuggestion(feedback: Feedback) {

diff --git a/...programming/manage/code-editor/code-editor-instructor-and-editor-container.component.html b/...programming/manage/code-editor/code-editor-instructor-and-editor-container.component.html
@@ -22,7 +22,6 @@
         [buildable]="selectedRepository !== REPOSITORY.TEST"
         [course]="course"
         [allowHiddenFiles]="true"
-        [useMonacoEditor]="true"
         (onResizeEditorInstructions)="onResizeEditorInstructions()"
     >
         <div editorTitle>

diff --git a/...webapp/app/exercises/programming/participate/code-editor-student-container.component.html b/...webapp/app/exercises/programming/participate/code-editor-student-container.component.html
@@ -24,7 +24,6 @@
     }
     @if (!loadingParticipation && !participationCouldNotBeFetched) {
         <jhi-code-editor-container
-            [useMonacoEditor]="true"
             [editable]="!repositoryIsLocked"
             [participation]="participation"
             [showEditorInstructions]="showEditorInstructions"

diff --git a/...in/webapp/app/exercises/programming/shared/code-editor/ace/code-editor-ace.component.html b/...in/webapp/app/exercises/programming/shared/code-editor/ace/code-editor-ace.component.html