-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stereotype visibility toggle button #367
Conversation
…reotype-visibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain to my why the changes so many changes are necessary? Maybe you can remove some changes that you did 🤔
I thought you just added the new svg icons, added a button, hid the stereotype in the elements, and persisted it. Why are the other changes necessary?
src/main/packages/common/uml-component/uml-component-update.tsx
Outdated
Show resolved
Hide resolved
...in/packages/uml-component-diagram/uml-component-subsystem/uml-component-subsystem-update.tsx
Outdated
Show resolved
Hide resolved
I will try to clarify my changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks generally good to me.
I added an improvment suggestion regarding the alignment whenever the stereotype is hidden.
Also have a look at the results of the Codacy Static Code Analysis, you are explicitly declaring a few types that can be inferred from the context.
src/main/packages/common/uml-component/uml-component-component.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and functionality look good to me now 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Checklist
[ ] I documented the TypeScript code using JSDoc style.[ ] I translated all the newly inserted strings into German and EnglishMotivation and Context
Closes #361
Description
I have added a button to the popups of Components and Subsystems in a Component diagram, and to the popups of Components and Nodes in a Deployment diagram, which toggles the visibility of the stereotype.
Steps for Testing
Test Coverage
Screenshots