Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS AppConfig API Data Source #758

Merged
merged 5 commits into from
Apr 1, 2024

Conversation

snowe2010
Copy link
Contributor

Proposed changes

Add an AWS AppConfig API Data Source

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

We need an AppConfig data source, and this was a simple addition alongside the lambda, dynamo, and athena plugins.

  • Add an AWS AppConfig API Data Source with several query options. Not all
    are implemented, but most of the main ones are.
  • Small fix to add 'no' option to list

Add an AWS AppConfig API Data Source with several query options. Not all
are implemented, but most of the main ones are.
certain apis provide a list of valid options, but null is also an
option.. this essentially adds that null option so that we can call
without providing a parameter. this is useful in github's api
Copy link

netlify bot commented Mar 15, 2024

👷 Deploy request for lowcoder-cloud pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 278ad55

@FalkWolsky FalkWolsky changed the base branch from main to dev March 15, 2024 23:44
Copy link

netlify bot commented Mar 16, 2024

👷 Deploy request for lowcoder-test pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 846f576

Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we ask you to prepare a small Postman Collection and add it instead of the api-examples? That would allow us to create soon a Lowcoder Workspace on Postman and collect all such API calls as demonstration. We think it would be more visible...

@snowe2010
Copy link
Contributor Author

snowe2010 commented Mar 16, 2024

I'm not actually sure I can, Postman refuses to let me sign in anymore. It's been broken since they changed from being a free service to mostly paid. :/

My team at work entirely switched to using the HTTP file standard which means you can easily store and run your collections directly from your IDE rather than in a proprietary software. It's worked out quite well. But yeah, it's definitely not as popular as Postman though :(

@snowe2010
Copy link
Contributor Author

Yeah I'm unable to sign in, so I can't save any requests so I can't export anything :(. I can remove the file if you don't want http files in the codebase, though I think they're much more open source friendly.

Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We love your contribution a lot, so we merge it now.
The api-examples file we may exchange with a Postman Collection later. As for now, we think you are right so we take it into the change. Thank you very much for your valuable contribution!!

@FalkWolsky FalkWolsky merged commit 80b006a into lowcoder-org:dev Apr 1, 2024
2 of 3 checks passed
@snowe2010 snowe2010 deleted the add-appconfig-query branch April 1, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants