-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default CPU for SPI ISR #426
Conversation
Fixes the error during SPI initialization: ``` E (417) spi_master: spi_master_init_driver(236): invalid core id W (417) LGFX: Failed to spi_bus_add_device. ``` Signed-off-by: Artem Senichev <[email protected]>
Looks like the CI process uses an old version of ESP-IDF. |
hi, thanks for your contribution 👍 the build failed for every esp32 job, can you describe the successful environment you used so it can be added to the workflows? isolating this change in a LFGX config block may avoid the pitfall of hitting incompatibility with older tested versions, it looks like isr_cpu_id hasn't always been a member of spi_bus_config_t:
in other situations (e.g. platformio), an extra include may be necessary to bring the missing define up to scope:
please enable the workflows on your fork so you can verify that every test succeds before submitting, also target the 'develop' branch instead of the master branch. |
LovyanGFX doesn't support the master branch of esp-idf, only some of their releases when the version number makes sense and has been thoroughly tested, this excludes the beta version you linked. Unfortunately v5.1 and 5.0.3 won't be added to the workflows until the release descriptions are disambiguated and evocate logic instead of version incest:
|
Ok. Just FYI, it works perfect with today's esp master, at least with WT32-SC01 =)
Sorry, then I close this PR. Thank you! |
FYI esp-idf 5.1 was added anyway to the CI tests on the develop branch https://github.com/lovyan03/LovyanGFX/blob/develop/.github/workflows/IDFBuild.yml |
I have enabled CI workflow for my fork, so all idf builds have passed, but all other (arduino, opencv, ...) has failed. I'm not sure if it's my fault =) |
The opencv error is probably due to a cache miss, it just means the opencv install script is outdated and needs to be rewritten but may be ignored for this PR. The ArduinoCIBuild has been disabled for long and isn't used any more so that error can be ignored too. Creating a new PR from/to develop branches will sure be the best way to verify this 👍 |
Fixes the error during SPI initialization: