Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support file for LILYGO T-Display S3 added #405

Closed
wants to merge 2 commits into from

Conversation

erazor83
Copy link

adds a file in lgfx_user for the display without touch.

Can be used like this:

#include "lgfx_user/LILYGO_T-Display-S3_ESP32-S3.hpp"
static LILYGO_TDisplay_S3 lcd;

@tobozo
Copy link
Collaborator

tobozo commented May 26, 2023

hi, thanks for sharing your work 👍

It may be a good idea to also submit your configuration snippet to the vendor repository.

@lovyan03
Copy link
Owner

@erazor83
Sorry for the late reply, and thanks for your PR !
Since pin_rd is set, the pixel readout function should be available.
If possible, check that the readout function is working by referring to #335 .

@lovyan03
Copy link
Owner

Please see the topic ahead from this comment.
#335 (comment)

@erazor83
Copy link
Author

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Inactive issues label Jul 10, 2023
@lovyan03
Copy link
Owner

 cfg.readable = false;

Please change this to true and try again.

@erazor83
Copy link
Author

Done and tested.

@github-actions github-actions bot removed the stale Inactive issues label Jul 12, 2023
@lovyan03
Copy link
Owner

Have you confirmed that the pixel readout deforms the image into a triangle?

@erazor83
Copy link
Author

No, sorry. Is this behavior documented somewhere? The display shows the same stuff which you can see on my gif I posted earlier.

@lovyan03
Copy link
Owner

image

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Inactive issues label Aug 17, 2023
@github-actions
Copy link

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

@github-actions github-actions bot closed this Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Inactive issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants