Add -fobjc-arc for love_3p_luahttps on macOS #2067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes error: "ARC is off"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
-fobjc-arcwhen building for love_3p_luahttps on macOS.Fixes error: "ARC is off"
I'm aware of the warning that "CMake is not an officially supported build system for love on Apple platforms"; this is a small step toward improving it.
This PR is for the main branch. The problem also affects the 12.0-development branch but that branch has not been updated in three months and other changes in CMakeLists.txt in the main branch mean this patch would have to be changed to apply to the 12.0-development branch.
The 11.x branch is not affected because the luahttps module was not used in that branch.