Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group liblove and lovedep projects in Visual Studio #2051

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

learn-more
Copy link
Contributor

This is the end result:

image

@slime73
Copy link
Member

slime73 commented Apr 6, 2024

From the linux build failure:

CMake Error at extra/cmake/LoveMacros.cmake:11 (get_target_property):
  get_target_property() called with non-existent target "lua51".
Call Stack (most recent call first):
  CMakeLists.txt:1926 (love_group_projects)

-- Configuring incomplete, errors occurred!

CMake Error at extra/cmake/LoveMacros.cmake:13 (if):
  if given arguments:

    "STREQUAL" "INTERFACE_LIBRARY"

  Unknown arguments specified

@learn-more
Copy link
Contributor Author

@slime73 This should now be fixed

@slime73
Copy link
Member

slime73 commented Apr 9, 2024

This seems ok to me, but I'd like someone with more cmake experience to look at it as well.

@bartbes
Copy link
Member

bartbes commented Apr 13, 2024

Would it make sense to also separate out the 3rd-party (love_3p) targets?

@learn-more
Copy link
Contributor Author

Would it make sense to also separate out the 3rd-party (love_3p) targets?

If you prefer that I can group those in a sub-folder as well.
Any suggestions for the name?
I'd think something like lovedep/third-party or so?

@slime73
Copy link
Member

slime73 commented Jun 16, 2024

Maybe liblove/libraries/ makes sense, given that they're in-source dependencies.

@learn-more
Copy link
Contributor Author

image

@slime73 slime73 merged commit 8ceae23 into love2d:main Jun 20, 2024
7 checks passed
@slime73
Copy link
Member

slime73 commented Jun 20, 2024

Looks good, thanks!

@learn-more learn-more deleted the vs_grouping branch June 21, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants