Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated love.graphics.stencil function resetting stencilMode #1999

Merged
merged 2 commits into from
Dec 24, 2023

Conversation

Raltyro
Copy link
Contributor

@Raltyro Raltyro commented Dec 24, 2023

Quite self-explanatory
Games from previous versions using deprecated stencil functions will most likely not working as intended

love.graphics.stencil(stencil, "replace", 1, false)
love.graphics.setStencilTest("greater", 0)

Example above vice versa would work the same in previous love2d version games but since currently stencil function resets the properties it wouldnt work the same

This pr fixes it

@slime73
Copy link
Member

slime73 commented Dec 24, 2023

Nice catch, thanks!

@slime73 slime73 merged commit 8423b82 into love2d:12.0-development Dec 24, 2023
6 checks passed
@Raltyro Raltyro deleted the patch-1 branch December 24, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants