fix reference to macos.mm #1953
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently geting alignment right pre-C++17 is not easy. Well, 2^32 fits entirely in Lua "double" 2^53 so it's fine to assume alignment of 1. Fixes #1916.
VS2013 doesn't support them.
When a fused löve executable is signed with codesign on Windows some data is appended to the executable, preventing physfs from finding the zip file at the end of the file. To help physfs out a bit, we try to find the zip ourselves in the case of regular mount failure by looking for it's characteristic end of central directory record and, once found, pretend to physfs that the file is shorter than it actually is and ends at the end of the zip file.
On 32-bit platforms, full-lightuserdata is always supported since their pointer fits entirely in 2^48 limitation that LuaJIT had in older version. Also suppress warning about key > 0x20000000000000ULL is always false on enet.cpp when compiling on 32-bit platforms.
Fixes #1880.
Add PHYSFS_Io StripSuffixIo to skip codesign signatures
Hash function fixes.
…sult if it's not there already.
…replacing an existing binding. issue #1936.
Fix #1943 - Duplicate frames being skipped when decoding Theora
Clamp the mouse coordinates to the window's dimensions.
slime73
reviewed
Jul 10, 2023
| @@ -328,7 +328,7 @@ set(LOVE_SRC_COMMON | |||
|
|
|||
| if (APPLE) | |||
| set(LOVE_SRC_COMMON ${LOVE_SRC_COMMON} | |||
| src/common/macosx.mm | |||
| src/common/macos.mm | |||
There was a problem hiding this comment.
This file is still macosx.mm in the main branch, it's only renamed to macos.mm in 12.0-development. Did you mean to make the PR based against that branch instead of main?
There was a problem hiding this comment.
Yes, I did. Sorry for the inconvenience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.