Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React legacy #177

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

React legacy #177

wants to merge 2 commits into from

Conversation

merraysy
Copy link

@merraysy merraysy commented Sep 15, 2019

I've created a new version that works with legacy react. It can be maintained in a different branch. Check out react-legacy branch. The trickiest part would be versioning :). I'd like to see how you'd handle that.

@lovasoa
Copy link
Owner

lovasoa commented Sep 16, 2019

Hello!
I'm sorry but I do not wish to maintain two versions of this library in parallel. I encourage you to publish your fork on npm, and maintain it separately if you do have the resources for that.

@merraysy
Copy link
Author

merraysy commented Sep 16, 2019

I can maintain it. I mean why we need to create a fork if I can maintain it in your repo.

@lovasoa
Copy link
Owner

lovasoa commented Sep 16, 2019

Well, these will be two distinct codebases that will need to be kept in sync manually, and pushed to different npm packages. What is the advantage of having them in the same repo? I can add a link to your repo and your npm package in our README, if you want.

@merraysy
Copy link
Author

merraysy commented Sep 16, 2019

You supported legacy React in version 2, I still can bump this version. it's cleaner that way without confusing people with two distinct packages on npm with different names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants