Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #356 #616

Closed
wants to merge 9 commits into from
Closed

Fix for #356 #616

wants to merge 9 commits into from

Conversation

DomiiBunn
Copy link
Contributor

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Fixes #356

Added a more graceful disconnect when removing an agent to ensure socket.io is not in a "stuck" state where it attempts to keep an open connection to a deleted agent as well as a re-trigger of sendAgentList to ensure the UI has a quick update on agent deletion.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings

@DomiiBunn
Copy link
Contributor Author

I messed up with the branches. Will re-open with the correct single fix commit

@DomiiBunn DomiiBunn closed this Sep 24, 2024
@DomiiBunn DomiiBunn deleted the Fix-for-#356 branch September 24, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[agents] Error from the socket server after agent removed
1 participant