Updates 20231027 #541
Merged
Updates 20231027 #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And, to detail::WorldConcept & detail::WorldModel respectively.
- Was a fine idea but hasn't made it into standard yet. - Even original author proposing an alternate. - Removing this reduces extraneous code and simplifies reading of World class.
And, into detail::JointConcept & detail::JointModel respectively.
And, into detail::ShapeConcept & detail::ShapeModel respectively.
- World class's member variable of same purpose. - Being a pointer to an *implementation*.
louis-langholtz
added
Enhancement
|
clang-tidy review says "All clean, LGTM! 👍" |
… UnitTests/World.cpp
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description - What's this PR do?
World.hpp,Shape.hpp, andJoint.hppfiles by moving their details out to separate files underdetailsubdirectory anddetailsub namespace.propagate_constand various other cleanups.