Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shape changes 20180109 #279

Merged
merged 10 commits into from
Jan 18, 2018
Merged

Shape changes 20180109 #279

merged 10 commits into from
Jan 18, 2018

Conversation

louis-langholtz
Copy link
Owner

@louis-langholtz louis-langholtz commented Jan 13, 2018 •
edited
Loading

Description - What's this PR do?

  • Renames playrho::d2::Draw* visiting functions to playrho::Visit* functions.
  • Ties in Testbed visitation of shapes more directly into the Visit function template.
  • Makes initialization construction of Shape instances explicit.
  • Updates documentation comments.

Related Issues

@louis-langholtz louis-langholtz added the Enhancement For suggestions or changes that enhance any part of the project and isn't a bug. label Jan 13, 2018
@louis-langholtz louis-langholtz added this to the Beta Launch milestone Jan 13, 2018
@louis-langholtz louis-langholtz self-assigned this Jan 13, 2018
@coveralls
Copy link

coveralls commented Jan 13, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.07%) to 98.214% when pulling bca2b7d on shape-changes-20180109 into f629809 on master.

@coveralls
Copy link

coveralls commented Jan 13, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 98.265% when pulling 0d193e2 on shape-changes-20180109 into f629809 on master.

@coveralls
Copy link

coveralls commented Jan 13, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.009%) to 98.275% when pulling dc6c452 on shape-changes-20180109 into f629809 on master.

@louis-langholtz
Refactors Visit function template to return a bool to provide sign th…
e42507c 
…at visitation did or didn't occur with the underlying type.
@coveralls
Copy link

coveralls commented Jan 14, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 98.296% when pulling e42507c on shape-changes-20180109 into f629809 on master.

@louis-langholtz
Switch from calling the C++ MultiShapeConf class a "class" to calling…
657c780 
… it a "struct" as it's actually defined to fix template ADL for Visit.
@louis-langholtz louis-langholtz merged commit 706269f into master Jan 18, 2018
@louis-langholtz louis-langholtz deleted the shape-changes-20180109 branch January 18, 2018 22:34
@louis-langholtz louis-langholtz mentioned this pull request Jan 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@louis-langholtz louis-langholtz

Labels
Enhancement For suggestions or changes that enhance any part of the project and isn't a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louis-langholtz @coveralls