feat: introduce flag noAdditionalProperties #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascal-hofmann
commented
Oct 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
==========================================
+ Coverage 99.06% 99.08% +0.02%
==========================================
Files 6 6
Lines 639 653 +14
==========================================
+ Hits 633 647 +14
Misses 4 4
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pascal-hofmann
force-pushed
the
feat/noAdditionalProperties
branch
2 times, most recently
from
9cfee26
to
5239364
Compare
|
I'll add a testcase that increases the coverage of |
This will default `additionalProperties` to `false` for all objects in the schema if set to `true`. The `additionalProperties` annotation, `schemaRoot.additionalProperties` and additionalProperties set via other ways (nested in `itemProperties`, `patternProperties` or similar) will take precedence over this setting, so it's fully backwards compatible. Closes losisin#95.
pascal-hofmann
force-pushed
the
feat/noAdditionalProperties
branch
from
5239364
to
b7c3e74
Compare
|
Coverage should be fine now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will default
additionalPropertiestofalsefor all objects in the schema if set totrue. TheadditionalPropertiesannotation,schemaRoot.additionalPropertiesand additionalProperties set via other ways (nested initemProperties,patternPropertiesor similar) will take precedence over this setting, so it's fully backwards compatible.Closes #95.