Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add documentation for item annotation and fix typos #96

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

pascal-hofmann
Copy link
Contributor

@pascal-hofmann pascal-hofmann commented Oct 24, 2024

The item annotation was added in #49, but README.md was not updated.

The `item` annotation was added in losisin#49, but README.md was not updated.
@pascal-hofmann pascal-hofmann changed the title docs: Add documentation for items annotation and fix typos docs: Add documentation for item annotation and fix typos Oct 24, 2024
@pascal-hofmann pascal-hofmann marked this pull request as draft October 24, 2024 06:00
@losisin losisin marked this pull request as ready for review October 24, 2024 06:35
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.06%. Comparing base (bee046f) to head (f259920).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
- Coverage   99.16%   99.06%   -0.10%     
==========================================
  Files           6        6              
  Lines         479      639     +160     
==========================================
+ Hits          475      633     +158     
- Misses          2        4       +2     
  Partials        2        2              
Flag Coverage Δ
unittests 99.06% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pascal-hofmann
Copy link
Contributor Author

pascal-hofmann commented Oct 24, 2024

I initially converted to draft, because I found some more missing things.

I'll add them in a separate PR later today/this week. Feel free to merge this one. 👍

@losisin
Copy link
Owner

losisin commented Oct 24, 2024

@pascal-hofmann thanks for the PR

@losisin losisin merged commit 6d1e5b0 into losisin:main Oct 24, 2024
2 of 3 checks passed
@pascal-hofmann pascal-hofmann deleted the improve-docs branch October 24, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants