Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows the Zip task to add content to an existing ZIP file, instead of overwriting it #254

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 77 additions & 0 deletions Source/MSBuild.Community.Tasks.Tests/ZipTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,83 @@ public void ZipWithParallelCompression()
Assert.IsTrue(unzipTask.Execute());
}


[Test(Description = "Zip file update instead of overwrite")]
public void ZipFileUpdate()
{
var task = new Zip();
task.BuildEngine = new MockBuild();

string testDir = TaskUtility.TestDirectory;
const string fileName = "zip-128kb-test-1.dat";
string testFile = Path.Combine(testDir, fileName);
const int numberOfBytes = 1024 * 128 * 9;
if (File.Exists(testFile))
File.Delete(testFile);
CreateTestFile(numberOfBytes, testFile);

task.Files = new[] { new TaskItem(testFile) };
task.WorkingDirectory = testDir;
task.ZipFileName = Path.Combine(testDir, ZIP_FILE_NAME);
task.Overwrite = false;

if (File.Exists(task.ZipFileName))
File.Delete(task.ZipFileName);

// First zip up the file
Assert.IsTrue(task.Execute(), "Execute Failed");
Assert.IsTrue(File.Exists(task.ZipFileName), "Zip file not found");

// Then delete the original, and try to unzip the file
File.Delete(testFile);
Unzip unzipTask = new Unzip();
unzipTask.BuildEngine = new MockBuild();
unzipTask.ZipFileName = task.ZipFileName;
unzipTask.TargetDirectory = testDir;
Assert.IsTrue(unzipTask.Execute());

long length = new FileInfo(Path.Combine(testDir, fileName)).Length;
Assert.AreEqual(numberOfBytes, length, "File length does not match");

if (File.Exists(testFile))
File.Delete(testFile);
CreateTestFile(numberOfBytes * 2, testFile);

// Update the zip file
Assert.IsTrue(task.Execute(), "Execute Failed");
Assert.IsTrue(File.Exists(task.ZipFileName), "Zip file not found");

// Then delete the original, and try to unzip the file
File.Delete(testFile);
unzipTask = new Unzip();
unzipTask.BuildEngine = new MockBuild();
unzipTask.ZipFileName = task.ZipFileName;
unzipTask.TargetDirectory = testDir;
Assert.IsTrue(unzipTask.Execute());

length = new FileInfo(Path.Combine(testDir, fileName)).Length;
Assert.AreEqual(numberOfBytes * 2, length, "File length does not match");

if (File.Exists(testFile))
File.Delete(testFile);
CreateTestFile(numberOfBytes, testFile);

// Update the zip file again
Assert.IsTrue(task.Execute(), "Execute Failed");
Assert.IsTrue(File.Exists(task.ZipFileName), "Zip file not found");

// Then delete the original, and try to unzip the file
File.Delete(testFile);
unzipTask = new Unzip();
unzipTask.BuildEngine = new MockBuild();
unzipTask.ZipFileName = task.ZipFileName;
unzipTask.TargetDirectory = testDir;
Assert.IsTrue(unzipTask.Execute());

length = new FileInfo(Path.Combine(testDir, fileName)).Length;
Assert.AreEqual(numberOfBytes, length, "File length does not match");
}

public void CreateTestFile(int fileSize, string filePath)
{
byte[] testFileBytes = new byte[fileSize];
Expand Down
Loading