Update pybind #66
Update pybind #66
Conversation
There was a problem hiding this comment.
I think this is fine as it is, but I'm thinking about including something to help a user to make it work with older python versions. Maybe we can add some info on how to use older pybind versions and add some cmake flags? I believe it's possible that some people don't have access to new python versions on older clusters/computers, and python 3.11 is really recent. What do you think?
| @@ -46,7 +46,7 @@ def check(to_check:List[str]=["python", "numpy", "matplotlib", "sklearn", "oxpy" | |||
| print("INFO: Python version: {}".format('.'.join([str(i) for i in version_info[0:3]])), file=stderr) | |||
| if version_info < (3, 9): | |||
| flag = True | |||
| print("WARNING: Some scripts will not run with Python versions earler than 3.8. You have {}, please update your environment", file=stderr) | |||
| print("WARNING: Some scripts will not run with Python versions earler than 3.9. You have {}, please update your environment", file=stderr) | |||
There was a problem hiding this comment.
I think there is a version_info missing in the print call
There was a problem hiding this comment.
And there is also a typo (earler should be earlier)
There was a problem hiding this comment.
As far as version requirements go, the oxpy/oat code in this pull request will work with Python 3.9-3.11 (haven't checked the bleeding edge 3.12). Because of changes to the CPython api, the current version of Pybind11 (2.11) only works with Python 3.8+. Because of some data structures and type hints in oat, it needs 3.9+.
I'm not familiar with CMake/make enough to do this easily, but is there an easy way to decouple oxpy from oat (since right now they're just installed in a single pip command, I think)? If so, we could give instructions on how to install just oxpy with older versions of Python by downloading an older version of Pybind11 and replacing the oxpy/pybind11 folder.
Thank you for noticing the errors. I will fix.
There was a problem hiding this comment.
I added a section to the Installation page of the documentation on how to replace the pybind11 folder and remove oat, which will allow oxpy to be installed with older Python versions.
Updated the included pybind version from 2.2 to 2.11 so that oxpy and oat work with Python 3.11. Pybind11 2.11 has a minimum Python version of 3.8, but because of oat's requirement of 3.9 I changed all requirements to match that.