Parse version from directory name if not a git repository. #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for the PR! I have added a suggestion in my review, but other than that I think we are good to go. |
|
It seems like your review is not showing up for me? |
|
Sorry about that, I started it, but forgot to finalise it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to address #141.
If git is not found, or if the directory is not a git repository, this instead tries to pull a version string from the source directory name. It will succeed on anything that looks like a three-level version string after a "-", and will include anything after that version, to allow the user to specify extra information after the version if desired.
As the current git-tag-finding code will include the initial 'v' in the tag, the directory-based version string will be slightly different (eg, "3.7.0" instead of "v3.7.0"). I can change this to be consistent with the git method if that would be better.