Skip to content

Commit

Permalink
Fix some bugs and docs errors due to the DRH -> NA change
Browse files Browse the repository at this point in the history
  • Loading branch information
lorenzo-rovigatti committed Nov 20, 2023
1 parent aaebaeb commit 79728d3
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion docs/source/configurations.md
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ CGCAAC type=DNA
```

```{note}
Setting `type` only affects the force field when using the DNA/RNA hybrid model (`interaction_type=DRH`). For normal DNA or RNA, the interactions will be determined by the `interaction_type=DNA|DNA2|RNA|RNA2|DRH|LJ...` parameter in the [input file](input.md)
Setting `type` only affects the force field when using the DNA/RNA hybrid model (`interaction_type=NA`). For normal DNA or RNA, the interactions will be determined by the `interaction_type=DNA|DNA2|RNA|RNA2|NA|LJ...` parameter in the [input file](input.md)
```

```{note}
Expand Down
2 changes: 1 addition & 1 deletion docs/source/install.md
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ cmake -DPython=1 -DPYTHON_EXECUTABLE=$HOME/miniconda3/bin/python -DPYTHON_INCLUD

## Testing

* `make test_run` runs quick tests to check that oxDNA has been correctly compiled, and that the core interactions (`DNA2`, `RNA2` and `DRH`) compute the energy contributions in a nicked double strand correctly.
* `make test_run` runs quick tests to check that oxDNA has been correctly compiled, and that the core interactions (`DNA2`, `RNA2` and `NA`) compute the energy contributions in a nicked double strand correctly.
* `make test_quick` runs longer tests to check that oxDNA works.
* `make test_oxpy` checks that the Python bindings work.
* `make test` runs all sets of tests above.
Expand Down
2 changes: 1 addition & 1 deletion src/Backends/VMMC_CPUBackend.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ void VMMC_CPUBackend::get_settings(input_file & inp) {
ok_interactions.push_back("DNA2_nomesh");
ok_interactions.push_back("RNA");
ok_interactions.push_back("RNA2");
ok_interactions.push_back("DRH");
ok_interactions.push_back("NA");
if(getInputString(&inp, "interaction_type", inter, 0) == KEY_FOUND) {
// std::find points is equal to ok_interactions.end() if it can't find inter in ok_interactions.
if(std::find(ok_interactions.begin(), ok_interactions.end(), inter) == ok_interactions.end()) {
Expand Down
2 changes: 1 addition & 1 deletion src/Interactions/DNAInteraction.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ void DNAInteraction::get_settings(input_file &inp) {
std::string inter_type;
getInputString(&inp, "interaction_type", inter_type, 0);

if(inter_type.compare("DRH") || inter_type.compare("DRH_relax")) {
if(inter_type.compare("NA") || inter_type.compare("NA_relax")) {
getInputString(&inp, "seq_dep_file_DNA", _seq_filename, 1);
} else {
getInputString(&inp, "seq_dep_file", _seq_filename, 1);
Expand Down
2 changes: 1 addition & 1 deletion src/Interactions/RNAInteraction.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ void RNAInteraction::get_settings(input_file &inp) {
if(!_average) {
std::string inter_type;
getInputString(&inp, "interaction_type", inter_type, 0);
if(inter_type.compare("DRH") || inter_type.compare("DRH_relax")) {
if(inter_type.compare("NA") || inter_type.compare("NA_relax")) {
getInputString(&inp, "seq_dep_file_RNA", _seq_filename, 1);
} else {
getInputString(&inp, "seq_dep_file", _seq_filename, 1);
Expand Down
2 changes: 1 addition & 1 deletion test/TestSuite.py
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ def __init__(self, list_file, executable, level, threads=1):
def launch(self):
for i in range(self.threads):
runner = Runner(i)
runner.setDaemon(True)
runner.daemon = True
runner.start()

for system in self.systems:
Expand Down

0 comments on commit 79728d3

Please sign in to comment.