Effects System: lord_effect: add mod backbone & register our effect…

…s for `speed`,`jump`,`health`. Relates to #1676

mods/lord/Core/effects/src/effects/Effect.lua

@@ -17,7 +17,7 @@ function Effect:new(name, type)
 	return setmetatable(self, { __index = class })
 end
 
---- @param start fun(self:effects.Effect,player:Player,amount:number)
+--- @param start fun(self:effects.Effect,player:Player,amount:number,duration:number)
 --- @return effects.Effect
 function Effect:on_start(start)
 	self.start = start

mods/lord/Core/effects/src/effects/Processor.lua

@@ -18,7 +18,7 @@ end
 --- @param duration number
 --- @param after_stop fun()
 function Processor.run_effect_for(player, effect, amount, duration, after_stop)
-	effect:start(player, amount)
+	effect:start(player, amount, duration)
 	-- TODO: effect can be reapplied. #1650
 	minetest.after(duration, function()
 		-- TODO: the `player` could have already left. #1673

mods/lord/Game/lord_effects/init.lua

@@ -0,0 +1,5 @@
+
+
+minetest.mod(function(mod)
+	require("lord_effects").init(mod)
+end)

mods/lord/Game/lord_effects/mod.conf

@@ -0,0 +1,2 @@
+name = lord_effects
+depends = builtin, effects, physics, damage

mods/lord/Game/lord_effects/src/lord_effects.lua

@@ -0,0 +1,47 @@
+
+
+lord_effects = {
+	SPEED  = 'speed',
+	JUMP   = 'jump',
+	HEALTH = 'health',
+	-- BREATH = 'breath', TODO: #1678
+}
+
+
+local function register_effects()
+	effects.register(
+		effects.Effect:new(lord_effects.SPEED)
+			:on_start(function(self, player, amount)
+				physics.for_player(player):set({ speed = amount })
+			end)
+			:on_stop(function(self, player)
+				physics.for_player(player):set({ speed = 1 })
+			end)
+	)
+	effects.register(
+		effects.Effect:new(lord_effects.JUMP)
+			:on_start(function(self, player, amount)
+				physics.for_player(player):set({ jump = amount })
+			end)
+			:on_stop(function(self, player)
+				physics.for_player(player):set({ jump = 1 })
+			end)
+	)
+	effects.register(
+		effects.Effect:new(lord_effects.HEALTH)
+			:on_start(function(self, player, amount, duration)
+				damage.Periodical:for_player(player):start(damage.Type.FLESHY, amount, duration)
+			end)
+			:on_stop(function(self, player)
+			    -- Periodical Damage stops itself.
+			end)
+	)
+end
+
+
+return {
+	--- @param mod minetest.Mod
+	init = function(mod)
+		register_effects()
+	end,
+}