Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RemoveObserver on EventBus interface, allows for httputils to remove once handled. #188

Closed
wants to merge 1 commit into from
Closed

Add RemoveObserver on EventBus interface, allows for httputils to remove once handled. #188

wants to merge 1 commit into from

Conversation

bweston92
Copy link

@bweston92 bweston92 commented Feb 28, 2018 •
edited
Loading

Fixes #187

@maxekman
Copy link
Member

maxekman commented Mar 1, 2018

Looks like a good addition. The mocks needs to be updated too, check the CI logs.

@maxekman
Copy link
Member

maxekman commented Sep 6, 2018

Hi @bweston92, I can merge this after you rebase and fix the issue with the mocks if you want. Thanks.

@maxekman
Copy link
Member

I'll close this as the affected interfaces and implementations has changed a lot. Feel free to re-open or file an issue.

@maxekman maxekman closed this Sep 17, 2018
@bweston92
Copy link
Author

Has the actual memory leak been sorted in master?

@maxekman
Copy link
Member

No, it is not addressed.

@maxekman
Copy link
Member

Sorry for not getting this in before the refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bweston92 @maxekman