Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fetch unique index information for columns #622

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aaqilniz
Copy link
Contributor

@aaqilniz aaqilniz commented Oct 13, 2024

This PR along with another PR@loopback-datasource-juggler will enable models to have index information.

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

@aaqilniz aaqilniz force-pushed the feat/fetch-index-info branch from befe74d to 423bc7f Compare October 14, 2024 14:40
@aaqilniz aaqilniz force-pushed the feat/fetch-index-info branch from 423bc7f to 6af3b7c Compare October 14, 2024 14:41
@aaqilniz aaqilniz changed the title feat: fetch index information for columns feat: fetch unique index information for columns Oct 15, 2024
@@ -199,6 +199,23 @@ describe('Discover model primary keys', function() {
});
});

describe('Discover user model with index', function() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add some more test cases to cover more negative scenarios and other worst cases ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants