Skip to content

Commit

Permalink
fix: enable migration for enum property
Browse files Browse the repository at this point in the history
Signed-off-by: Muhammad Aaqil <[email protected]>
  • Loading branch information
aaqilniz committed Apr 14, 2024
1 parent 858adf3 commit f10ae9f
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 1 deletion.
9 changes: 9 additions & 0 deletions lib/migration.js
Original file line number Diff line number Diff line change
Expand Up @@ -764,10 +764,19 @@ function mixinMigration(MySQL, mysql) {
const colLength = columnMetadata && columnMetadata.dataLength || prop.length || prop.limit;
const colPrecision = columnMetadata && columnMetadata.dataPrecision;
const colScale = columnMetadata && columnMetadata.dataScale;
let enumList = '';
if(colType && colType === 'ENUM') {

Check failure on line 768 in lib/migration.js

View workflow job for this annotation

GitHub Actions / Code Lint

Expected space(s) after "if"

Check failure on line 768 in lib/migration.js

View workflow job for this annotation

GitHub Actions / build (18)

Expected space(s) after "if"

Check failure on line 768 in lib/migration.js

View workflow job for this annotation

GitHub Actions / build (20)

Expected space(s) after "if"
if(prop.jsonSchema && prop.jsonSchema.enum) {

Check failure on line 769 in lib/migration.js

View workflow job for this annotation

GitHub Actions / Code Lint

Expected space(s) after "if"

Check failure on line 769 in lib/migration.js

View workflow job for this annotation

GitHub Actions / build (18)

Expected space(s) after "if"

Check failure on line 769 in lib/migration.js

View workflow job for this annotation

GitHub Actions / build (20)

Expected space(s) after "if"
prop.jsonSchema.enum.forEach(item => {
enumList += `'${item}'`;
});
}
}
// info on setting column specific properties
// i.e dataLength, dataPrecision, dataScale
// https://loopback.io/doc/en/lb3/Model-definition-JSON-file.html
if (colType) {
if (colType === 'ENUM') return colType + '(' + enumList + ')';
if (colLength) return colType + '(' + colLength + ')';
if (colPrecision && colScale) return colType + '(' + colPrecision + ',' + colScale + ')';
if (colPrecision) return colType + '(' + colPrecision + ')';
Expand Down
10 changes: 9 additions & 1 deletion test/migration.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,13 @@ describe('migrations', function() {
Key: '',
Default: null,
Extra: ''},
typings: {
Field: 'typings',
Type: "enum('A','B')",
Null: 'YES',
Key: '',
Default: null,
Extra: ''},
});
done();
});
Expand Down Expand Up @@ -548,9 +555,10 @@ function setup(done) {
require('./init.js');

db = global.getSchema();

const customType = db.EnumFactory('A', 'B');
UserData = db.define('UserData', {
email: {type: String, null: false, index: true},
typings: {type: customType},
name: String,
bio: Schema.Text,
birthDate: Date,
Expand Down

0 comments on commit f10ae9f

Please sign in to comment.