fix: reading error code

Signed-off-by: Muhammad Aaqil <[email protected]>
loopbackio · Apr 17, 2024 · de5eac7 · de5eac7
1 parent 9512f15
commit de5eac7
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/lib/set-http-code.js b/lib/set-http-code.js
@@ -26,14 +26,16 @@ const codes = {
  * add your SQL error to the correct HTTP code array above!
  */
 module.exports = function(err) {
+  let code = '';
+  if (err && err.code) code = err.code;
   if (!err) {
     return;
   } else if (!(err instanceof Error)) {
     err = new Error(err); // Sucks that we weren't given an error object...
   }
   // Find error prefix
   const msg = err.message;
-  const sqlError = msg.substring(0, msg.indexOf(':'));
+  const sqlError = msg.substring(0, msg.indexOf(':')) || code;
 
   for (const code in codes) {
     if (_.includes(codes[code], sqlError)) {

diff --git a/test/set-http-code.test.js b/test/set-http-code.test.js
@@ -29,6 +29,18 @@ describe('setHttpCode', function() {
       });
     }
   });
+
+  it('should set statusCode from code', function() {
+    let err = {
+      message: 'Duplicate entry \'value\' for key \'key_name\'',
+      code: 'ER_DUP_ENTRY',
+    };
+    err = setHttpCode(err);
+    should.exist(err.statusCode);
+    should(err instanceof Error);
+    should.equal(err.statusCode, 422);
+  });
+
   it('should do nothing without error', function() {
     should.doesNotThrow(setHttpCode);
   });