Fix spinner height to maximum at 45deg #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the spinner element rotates it would behave poorly when displayed in a context where it contributes to the height of a parent element, especially if that parent element scrolls. By fixing the height at the maximum height the spinner will become when rotated to e.g. 45deg we ensure that it's always the same size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the spinner element rotates it would behave poorly when displayed in a context where it contributes to the height of a parent element, especially if that parent element scrolls. By fixing the height at the maximum height the spinner will become when rotated to e.g. 45deg we ensure that it's always the same size.
Here's an example of the problem:
Screen.Recording.2024-06-14.at.17.30.53.mov
After this PR the size will be fixed.
Because this uses a pseudo element we don't need to change the corresponding HTML structure making this change backwards compatible