Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved city looting to default.lua #2508

Merged
merged 1 commit into from
Jan 19, 2025
Merged

Conversation

XHawk87
Copy link
Collaborator

@XHawk87 XHawk87 commented Jan 18, 2025

Closes #2307

Requires #2473

@jwrober
Copy link
Collaborator

jwrober commented Jan 18, 2025

Code looks ok to me. How does one test this?

@XHawk87
Copy link
Collaborator Author

XHawk87 commented Jan 19, 2025

I started an LTX local game, let the AI play a few turns, then took over one of them and spawned myself some units using lua and took some cities.

@jwrober jwrober self-requested a review January 19, 2025 20:16
@jwrober jwrober merged commit 6fbed01 into longturn:master Jan 19, 2025
21 checks passed
@XHawk87 XHawk87 added the back-port back-port candidate label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-port back-port candidate
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Ruleset or server setting for disabling gold looting when a city is conquered
2 participants