Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored bounce_unit to allow reporting using function callbacks #2480

Merged
merged 4 commits into from
Jan 6, 2025
Merged

Refactored bounce_unit to allow reporting using function callbacks #2480

merged 4 commits into from
Jan 6, 2025

Conversation

XHawk87
Copy link
Collaborator

@XHawk87 XHawk87 commented Jan 2, 2025

Closes #2478

lmoureaux
lmoureaux reviewed Jan 3, 2025
View reviewed changes
Copy link
Contributor

@lmoureaux lmoureaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the changes, but this included a fix for the equivalent of #2477 in bounce_unit that won't work (we can also do this part later).

server/unittools.cpp Outdated Show resolved Hide resolved
server/unittools.cpp Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
server/maphand.cpp Show resolved Hide resolved
server/unittools.cpp Outdated Show resolved Hide resolved
server/unittools.cpp Show resolved Hide resolved
server/unittools.h Show resolved Hide resolved
@XHawk87 XHawk87 mentioned this pull request Jan 3, 2025
Open
@XHawk87 XHawk87 requested a review from lmoureaux January 3, 2025 04:47
lmoureaux
lmoureaux requested changes Jan 6, 2025
View reviewed changes
server/unittools.cpp Show resolved Hide resolved
@XHawk87 XHawk87 force-pushed the bounce_unit_refactor branch from 419c771 to 56f5135 Compare January 6, 2025 07:05
@XHawk87 XHawk87 requested a review from lmoureaux January 6, 2025 07:07
@lmoureaux lmoureaux enabled auto-merge (rebase) January 6, 2025 12:07
auto-merge was automatically disabled January 6, 2025 12:13

Head branch was pushed to by a user without write access

@lmoureaux lmoureaux merged commit 1f5d461 into longturn:master Jan 6, 2025
21 of 22 checks passed
@XHawk87 XHawk87 deleted the bounce_unit_refactor branch January 6, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmoureaux lmoureaux lmoureaux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor bounce_unit to split out additional responsibilities into separate functions
2 participants
@XHawk87 @lmoureaux