Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(1.7.1): update important-notes #979

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

derekbit
Copy link
Member

@derekbit derekbit commented Aug 30, 2024

Add "Add "Volume Locality for RWX Volumes"

Which issue(s) this PR fixes:

Issue #

What this PR does / why we need it:

Special notes for your reviewer:

Additional documentation or context

@derekbit derekbit requested a review from innobead August 30, 2024 07:54
@derekbit derekbit self-assigned this Aug 30, 2024
@derekbit derekbit changed the title docs(1.7.0): update important-notes docs(1.7.1): update important-notes Aug 30, 2024
@derekbit derekbit marked this pull request as ready for review August 30, 2024 07:54
@derekbit derekbit requested a review from a team as a code owner August 30, 2024 07:55
Copy link

netlify bot commented Aug 30, 2024

Deploy Preview for longhornio ready!

Name Link
🔨 Latest commit c898a23
🔍 Latest deploy log https://app.netlify.com/sites/longhornio/deploys/66d17aaf0abbd800086b8003
😎 Deploy Preview https://deploy-preview-979--longhornio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 30, 2024

Deploy Preview for longhornio ready!

Name Link
🔨 Latest commit 9569fcc
🔍 Latest deploy log https://app.netlify.com/sites/longhornio/deploys/66d28d8b05fff1000807e2bf
😎 Deploy Preview https://deploy-preview-979--longhornio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

innobead
innobead previously approved these changes Aug 31, 2024
Copy link
Member

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The statement is captured from the original page which has been reviewed, so doc review can be skipped.​​​​​​​​​​​​​​​​

@innobead
Copy link
Member

@derekbit Have we figured out the failed PR checks?

@derekbit
Copy link
Member Author

@derekbit Have we figured out the failed PR checks?

Fixed the link error. Thank you.

@derekbit derekbit requested a review from innobead August 31, 2024 03:23
@derekbit
Copy link
Member Author

BTW, I removed the last replica handling from my PR. @ejweber has added it in #980.

- Add "Volume Locality for RWX Volumes"

Signed-off-by: Derek Su <[email protected]>
@innobead
Copy link
Member

@derekbit lets update the description of this PR, since it still mentioned last replica.

@derekbit
Copy link
Member Author

@derekbit lets update the description of this PR, since it still mentioned last replica.

Updated. Thanks.

@innobead innobead merged commit 4ca2728 into longhorn:master Aug 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants