Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update volume encryption doc #775

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Update volume encryption doc #775

merged 1 commit into from
Nov 28, 2023

Conversation

derekbit
Copy link
Member

@derekbit derekbit requested a review from innobead September 19, 2023 10:55
@derekbit derekbit requested a review from a team as a code owner September 19, 2023 10:55
@derekbit derekbit self-assigned this Sep 19, 2023
@derekbit derekbit mentioned this pull request Sep 19, 2023
Closed
@innobead
Copy link
Member

@jillian-maroket please help review this. Thanks.

innobead
innobead previously approved these changes Sep 19, 2023
View reviewed changes
jillian-maroket

This comment was marked as duplicate.

Sign in to view

jillian-maroket
jillian-maroket reviewed Oct 18, 2023
View reviewed changes
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if the changes work.

content/docs/1.6.0/advanced-resources/security/volume-encryption.md Outdated Show resolved Hide resolved
content/docs/1.6.0/advanced-resources/security/volume-encryption.md Outdated Show resolved Hide resolved
content/docs/1.6.0/advanced-resources/security/volume-encryption.md Outdated Show resolved Hide resolved
@innobead
Copy link
Member

@derekbit Please check the review comment from @jillian-maroket .

@netlify Netlify
Copy link

netlify bot commented Nov 24, 2023 •
edited
Loading

✅ Deploy Preview for longhornio ready!

Name Link
🔨 Latest commit 4b6ef97
🔍 Latest deploy log https://app.netlify.com/sites/longhornio/deploys/65607d0c85982a000980f278
😎 Deploy Preview https://deploy-preview-775--longhornio.netlify.app/docs/1.6.0/advanced-resources/security/volume-encryption
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jillian-maroket
jillian-maroket reviewed Nov 24, 2023
View reviewed changes
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A suggested change was missed. Please check.

content/docs/1.6.0/advanced-resources/security/volume-encryption.md Outdated Show resolved Hide resolved
@derekbit
Update volume encryption doc
4b6ef97 
Longhorn 4883

Signed-off-by: Derek Su <[email protected]>
@innobead innobead merged commit 35fc225 into longhorn:master Nov 28, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jillian-maroket jillian-maroket jillian-maroket approved these changes

@innobead innobead innobead approved these changes

Assignees

@derekbit derekbit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derekbit @innobead @jillian-maroket