Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(os/distro): OCP/OKD support #765

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Conversation

mantissahz
Copy link
Contributor

Add/modify documents to support deploying Longhorn on OPCP/OKD

Ref: longhorn/longhorn#1831

@derekbit
Copy link
Member

derekbit commented Aug 16, 2023

I think the doc can be put in Deploy chapter, e.g. Deploy > OCP/OKD support.

@mantissahz mantissahz changed the title feat(os/distro): OCP/OKD support doc(os/distro): OCP/OKD support Aug 17, 2023
@mantissahz mantissahz force-pushed the issue1831 branch 6 times, most recently from c3d35bf to 79661bd Compare August 18, 2023 04:23
@innobead
Copy link
Member

cc @ArthurVardevanyan

@innobead
Copy link
Member

innobead commented Aug 28, 2023

@mantissahz Please mention @ArthurVardevanyan is the main contributor for this feature in the doc. Thanks.

weight: 4
---

To deploy Longhorn on a cluster provisioned with OpenShift 4.x, some additional configurations is required.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified. Thanks.


## Prerequisite

If you don't want to use the default disk as the Longhorn storage, set ***defaultSettings.createDefaultDiskLabeledNodes*** true when installing Longhorn by helm:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, users don't need to set up a dedicated disk if they just try this setup, so this is not really a prerequisite but rather an example to teach users how to create a customized default longhorn disk by using MachineConfig.

Thus, I would suggest change prerequisite to Prepare a customized default longhorn disk (Optional), then move all original subsections into this section. At the beginning of the section, you can briefly explain the purpose of it and it's actually optional if users just use the default longhorn disk.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved the section prerequisite to Prepare a customized default longhorn disk (Optional) and add more descriptions in this section. Thanks

Add/modify documents to support deploying Longhorn with OCP/OKD 4.x

Ref: 1831

Signed-off-by: James Lu <[email protected]>
@innobead innobead merged commit 4919591 into longhorn:master Sep 11, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants