-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(os/distro): OCP/OKD support #765
Conversation
I think the doc can be put in |
content/docs/1.6.0/advanced-resources/os-distro-specific/additional-configurations-on-okd.md
Outdated
Show resolved
Hide resolved
content/docs/1.6.0/advanced-resources/os-distro-specific/additional-configurations-on-okd.md
Outdated
Show resolved
Hide resolved
content/docs/1.6.0/advanced-resources/os-distro-specific/additional-configurations-on-okd.md
Outdated
Show resolved
Hide resolved
content/docs/1.6.0/advanced-resources/os-distro-specific/additional-configurations-on-okd.md
Outdated
Show resolved
Hide resolved
content/docs/1.6.0/advanced-resources/os-distro-specific/additional-configurations-on-okd.md
Outdated
Show resolved
Hide resolved
c3d35bf
to
79661bd
Compare
content/docs/1.6.0/advanced-resources/os-distro-specific/okd-support.md
Outdated
Show resolved
Hide resolved
content/docs/1.6.0/advanced-resources/os-distro-specific/okd-support.md
Outdated
Show resolved
Hide resolved
content/docs/1.6.0/advanced-resources/os-distro-specific/okd-support.md
Outdated
Show resolved
Hide resolved
@mantissahz Please mention @ArthurVardevanyan is the main contributor for this feature in the doc. Thanks. |
286ed8a
to
04792b4
Compare
weight: 4 | ||
--- | ||
|
||
To deploy Longhorn on a cluster provisioned with OpenShift 4.x, some additional configurations is required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modified. Thanks.
|
||
## Prerequisite | ||
|
||
If you don't want to use the default disk as the Longhorn storage, set ***defaultSettings.createDefaultDiskLabeledNodes*** true when installing Longhorn by helm: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, users don't need to set up a dedicated disk if they just try this setup, so this is not really a prerequisite but rather an example to teach users how to create a customized default longhorn disk by using MachineConfig
.
Thus, I would suggest change prerequisite
to Prepare a customized default longhorn disk (Optional)
, then move all original subsections into this section. At the beginning of the section, you can briefly explain the purpose of it and it's actually optional if users just use the default longhorn disk.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved the section prerequisite
to Prepare a customized default longhorn disk (Optional)
and add more descriptions in this section. Thanks
04792b4
to
2186066
Compare
2186066
to
0308316
Compare
Add/modify documents to support deploying Longhorn with OCP/OKD 4.x Ref: 1831 Signed-off-by: James Lu <[email protected]>
0308316
to
2b60bfd
Compare
Add/modify documents to support deploying Longhorn on OPCP/OKD
Ref: longhorn/longhorn#1831