Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(1.8.0): add automatic RWX expansion #1012

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

james-munson
Copy link
Contributor

Which issue(s) this PR fixes:

Issue longhorn/longhorn#9736

What this PR does / why we need it:

Document changes to RWX online expansion sequence.

Special notes for your reviewer:

Additional documentation or context

Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for longhornio ready!

Name Link
🔨 Latest commit 0c834d8
🔍 Latest deploy log https://app.netlify.com/sites/longhornio/deploys/674106541c038b000800027b
😎 Deploy Preview https://deploy-preview-1012--longhornio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@jhkrug jhkrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small suggestions for your consideration. Thank you.

content/docs/1.8.0/nodes-and-volumes/volumes/expansion.md Outdated Show resolved Hide resolved
content/docs/1.8.0/nodes-and-volumes/volumes/expansion.md Outdated Show resolved Hide resolved
content/docs/1.8.0/nodes-and-volumes/volumes/expansion.md Outdated Show resolved Hide resolved
content/docs/1.8.0/nodes-and-volumes/volumes/expansion.md Outdated Show resolved Hide resolved
content/docs/1.8.0/nodes-and-volumes/volumes/expansion.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jhkrug jhkrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment on lines +138 to +140
```shell
kubectl -n longhorn-system delete pod <the share manager pod>
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this replies on RWX volume's failover feature. Can we provide two methods

  1. Scale down the workloads using the RWX volume
  2. Delete the share-manager pod and recreate it. Need to mention why this works.

WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the scale-down is covered by the Offline section below.
Are you asking that we make it clearer that these are alternatives by numbering them 1 and 2?

@derekbit derekbit merged commit e0a3338 into longhorn:master Nov 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants