feat(auto-salvage): v2 support #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c3y1huang
force-pushed
the
8430-feat-v2-auto-salvage
branch
5 times, most recently
from
8d0fe41 to
1fc6fe5
Compare
DamiaSan
approved these changes
Sep 27, 2024
longhorn/longhorn-8430 Signed-off-by: Chin-Ya Huang <[email protected]>
longhorn/longhorn-8430 Signed-off-by: Chin-Ya Huang <[email protected]>
c3y1huang
force-pushed
the
8430-feat-v2-auto-salvage
branch
from
1fc6fe5 to
6c849ff
Compare
longhorn/longhorn-8430 Signed-off-by: Chin-Ya Huang <[email protected]>
c3y1huang
force-pushed
the
8430-feat-v2-auto-salvage
branch
from
6c849ff to
01e88dd
Compare
derekbit
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#8430
What this PR does / why we need it:
Introducing the
ReplicaSnapshotDiskInfofield to theControllerReplicamessage. This allows to retrieval of snapshot information and populatesReplica.Status.Snapshotsfield. TheReplica.Status.Snapshotsfield is used for comparing snapshot sets when selecting a usable replica during auto-salvaging for v2 volumes.Special notes for your reviewer:
NoneAdditional documentation or context
None