-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(robot): skip test case Test Uninstall When Backing Image Exists #2276
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Yang Chiu <[email protected]>
WalkthroughThe pull request involves modifying the Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
e2e/tests/regression/test_backing_image.robot (1)
36-41
: LGTM! Consider enhancing the skip documentation.The addition of the
robot:skip
tag and Skip keyword follows Robot Framework best practices. However, to improve maintainability, consider adding more context about the blocking issue in the skip message.- Skip The original issue has not been resolved yet. + Skip Blocked by issue #10044: The uninstallation with backing images is not working as expected yet.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
e2e/tests/regression/test_backing_image.robot
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Build images
- GitHub Check: Summary
Which issue(s) this PR fixes:
Issue longhorn/longhorn#10044 longhorn/longhorn#10219
What this PR does / why we need it:
skip test case Test Uninstall When Backing Image Exists
Special notes for your reviewer:
Additional documentation or context
Summary by CodeRabbit