test(robot): fix Test Migration Confirm for v2 volume

[chriscchien]

Which issue(s) this PR fixes:

What this PR does / why we need it:

fix Test Migration Confirm for v2 volume

Special notes for your reviewer:

Additional documentation or context

Test result

v1.8.x v2 data engine : https://ci.longhorn.io/job/private/job/longhorn-e2e-test/2308/
v1.8.x v1 data engine : https://ci.longhorn.io/job/private/job/longhorn-e2e-test/2310/

Summary by CodeRabbit

Summary by CodeRabbit

• New Features

  • Updated migration criteria by removing checks for engine and replica differences during migration success.

• Bug Fixes

  • Adjusted the migration test cases to reflect the change in expected outcomes, removing the assertion that migration should succeed.

[coderabbitai]

Walkthrough

The pull request removes the Volume ${volume_id} migration should succeed keyword from the end-to-end testing resource, which previously asserted that the engine and replicas of a specified volume should differ for a successful migration. Additionally, the test cases in test_migration.robot are updated to reflect this change, removing the explicit assertion that migration should succeed while retaining the rollback failure condition.

Changes

File	Change Summary
e2e/keywords/migration.resource	Removed Volume ${volume_id} migration should succeed keyword, eliminating checks for engine and replica differences during migration.
e2e/tests/regression/test_migration.robot	Modified test cases to remove assertion for migration success while retaining rollback checks.

Possibly related PRs

• test(robot): migrate test case test_migration_rollback #2179: The removal of a keyword related to migration success criteria aligns with modifications in test_migration.robot where the assertion for migration success was also removed.
• test(robot): add node down during migration test cases #2208: Adds test cases simulating scenarios where nodes go down during migration, directly related to the changes in migration success criteria and rollback behavior.
• test(robot): fix migration confirmation after migration node down test case for v2 volumes #2195: Addresses migration confirmation for v2 volumes when a migration node is down, relevant to the changes affecting migration success criteria.
• test(robot): v2 volume should cleanup resources when instance manager is deleted #2199: Focuses on ensuring proper cleanup of resources when an instance manager is deleted, relating to the migration process and its success criteria.
• test(integration): test_rwx.py support v2 volume #2201: Enhances the test_rwx.py script to support v2 volumes, indirectly relating to migration changes involving volume management.
• test(integration): test_statefulset.py support v2 volume #2203: Adds support for v2 volumes in the test_statefulset.py file, relevant to the context of volume management and migration.

Suggested reviewers

• yangchiu

Poem

🐰 In the land of migration, we make a change,
Removing old checks, it's time to rearrange.
Volumes flow freely, no need to compare,
Rollbacks still matter, we handle with care.
Hopping through tests, with joy we declare! 🎉

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d4f866e and 8b5dd73.

📒 Files selected for processing (2)

• e2e/keywords/migration.resource (0 hunks)
• e2e/tests/regression/test_migration.robot (1 hunks)

💤 Files with no reviewable changes (1)

• e2e/keywords/migration.resource

🔇 Additional comments (1)

e2e/tests/regression/test_migration.robot (1)

41-41: Consider reintroducing or replacing the migration success check.
By removing the explicit validation keyword (e.g., Volume 0 migration should succeed), the test no longer verifies that the engine and replica states changed during the migration. This might hide issues if the volume doesn't fully migrate. Consider adding a more explicit confirmation step to ensure that the migration is indeed successful and the engine is operating on the target node.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

e2e/keywords/migration.resource (1)

49-49: Improve maintainability by documenting reasoning.
Adding an inline comment or docstring about why v2 volumes require identical replicas provides clarity to future maintainers.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b80aa68 and d4f866e.

📒 Files selected for processing (1)

• e2e/keywords/migration.resource (1 hunks)

🔇 Additional comments (1)

e2e/keywords/migration.resource (1)

49-53: Confirm consistency of engine and replica checks for v2.
This block introduces a conditional check that sets replicas to be the same when DATA_ENGINE is 'v2'. Meanwhile, the engine is always expected to be different (unconditionally). If the intended behavior is to have the engine remain the same as well when DATA_ENGINE is 'v2', consider adding a corresponding conditional check for the engine too.

[yangchiu]

Suggest removing Volume ${volume_id} migration should succeed step from the test case directly.

Also, too many typos in the description #2224 (comment).

[chriscchien]

Suggest removing Volume ${volume_id} migration should succeed step from the test case directly.

Also, too many typos in the description #2224 (comment).

Updated, I also deleted keyword Volume ${volume_id} migration should succeed because it is nowhere to use now.

[yangchiu]

LGTM

[yangchiu]

@mergify backport v1.8.x

[mergify]

backport v1.8.x

✅ Backports have been created

• #2245 test(robot): fix Test Migration Confirm for v2 volume (backport #2224) has been created for branch v1.8.x