test(robot): fix migration confirmation after migration node down test case for v2 volumes

[yangchiu]

Which issue(s) this PR fixes:

Issue longhorn/longhorn#10001

What this PR does / why we need it:

Fix migration confirmation after migration node down test case for v2 volumes.
Since v2 volumes delete stopped replicas on down nodes, replica name checks will fail for v2 volumes.

Special notes for your reviewer:

Additional documentation or context

Summary by CodeRabbit

• Bug Fixes
  • Updated the migration confirmation test case to streamline the process by removing unnecessary steps.

[coderabbitai]

Walkthrough

The pull request modifies the live_migration.robot test case by removing two specific steps: one for retrieving volume engine and replica names, and another for verifying migration failure or rollback. The remaining test steps continue to focus on volume creation, node attachment, migration node power-off, volume detachment, and post-migration status and data integrity checks.

Changes

File	Change Summary
e2e/tests/negative/live_migration.robot	Removed steps related to volume engine/replica name retrieval and migration failure verification

Suggested Reviewers

• chriscchien

Possibly Related PRs

• test(robot): add test case Migration Confirmation After Migration Node Down #2186: Introduces a similar test case for migration confirmation
• ci: fix test failures caused by unstable harvester cluster #2144: Addresses unstable harvester cluster test failures
• fix(node): cleanup node exec in test case teardown #2157: Performs test case cleanup operations
• test(robot): migrate test_replica_rebuild_per_volume_limit #2159: Adds volume management keywords
• test(robot): wait for pvc and volume deleted when cleaning up statefulset #2187: Ensures proper deletion of persistent volume claims and volumes

Poem

🐰 A Migration Tale of Robotic Grace
Steps trimmed, test case now leans
Nodes power down, volumes dance
In the realm of e2e's embrace
Simplicity wins the test's race! 🤖

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c8516c1 and 0e04765.

📒 Files selected for processing (1)

• e2e/tests/negative/live_migration.robot (0 hunks)

💤 Files with no reviewable changes (1)

• e2e/tests/negative/live_migration.robot

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[chriscchien]

LGTM