ci: scale up coredns to 3 replicas to prevent it from being affected by node down test cases #2181
Conversation
|
Warning Rate limit exceeded@yangchiu has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 5 minutes and 2 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe changes in this pull request involve the addition of a new function, Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (3)
pipelines/e2e/scripts/longhorn-setup.sh(1 hunks)pipelines/utilities/coredns.sh(1 hunks)test_framework/scripts/longhorn-setup.sh(2 hunks)
🧰 Additional context used
🪛 Shellcheck (0.10.0)
pipelines/utilities/coredns.sh
[error] 1-1: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
(SC2148)
🔇 Additional comments (2)
test_framework/scripts/longhorn-setup.sh (2)
9-9: LGTM: Properly sourced CoreDNS utility.
The CoreDNS utility script is correctly sourced alongside other utility scripts.
567-568: LGTM: Consistent implementation with e2e script.
The scale_up_coredns function is called at the appropriate time in the setup process, maintaining consistency with the e2e implementation.
pipelines/utilities/coredns.sh
Outdated
| scale_up_coredns(){ | ||
| kubectl patch deployment coredns -n kube-system --type='merge' -p '{"spec": {"replicas": 3}}' | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Add shell options and error handling.
The script needs improvements for robustness and error handling:
- Add shebang and shell options
- Add error handling and validation
Apply this diff:
+#!/bin/bash
+
+set -euo pipefail
+
scale_up_coredns(){
+ echo "Scaling CoreDNS deployment to 3 replicas..."
+
+ # Verify current replicas to avoid unnecessary patches
+ current_replicas=$(kubectl get deployment coredns -n kube-system -o=jsonpath='{.spec.replicas}' || echo "0")
+ if [ "$current_replicas" = "3" ]; then
+ echo "CoreDNS deployment already has 3 replicas"
+ return 0
+ fi
+
kubectl patch deployment coredns -n kube-system --type='merge' -p '{"spec": {"replicas": 3}}'
+
+ # Verify the patch was applied
+ if ! kubectl rollout status deployment/coredns -n kube-system --timeout=60s; then
+ echo "Failed to scale CoreDNS deployment"
+ return 1
+ fi
+
+ echo "Successfully scaled CoreDNS deployment to 3 replicas"
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| scale_up_coredns(){ | |
| kubectl patch deployment coredns -n kube-system --type='merge' -p '{"spec": {"replicas": 3}}' | |
| } | |
| #!/bin/bash | |
| set -euo pipefail | |
| scale_up_coredns(){ | |
| echo "Scaling CoreDNS deployment to 3 replicas..." | |
| # Verify current replicas to avoid unnecessary patches | |
| current_replicas=$(kubectl get deployment coredns -n kube-system -o=jsonpath='{.spec.replicas}' || echo "0") | |
| if [ "$current_replicas" = "3" ]; then | |
| echo "CoreDNS deployment already has 3 replicas" | |
| return 0 | |
| fi | |
| kubectl patch deployment coredns -n kube-system --type='merge' -p '{"spec": {"replicas": 3}}' | |
| # Verify the patch was applied | |
| if ! kubectl rollout status deployment/coredns -n kube-system --timeout=60s; then | |
| echo "Failed to scale CoreDNS deployment" | |
| return 1 | |
| fi | |
| echo "Successfully scaled CoreDNS deployment to 3 replicas" | |
| } |
🧰 Tools
🪛 Shellcheck (0.10.0)
[error] 1-1: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
(SC2148)
| @@ -55,6 +55,8 @@ main(){ | |||
| install_backupstores | |||
| install_csi_snapshotter | |||
|
|
|||
| scale_up_coredns | |||
There was a problem hiding this comment.
💡 Codebase verification
Missing source statement for CoreDNS utilities
The scale_up_coredns function is defined in pipelines/utilities/coredns.sh, but this file is not sourced in longhorn-setup.sh or any of its sourced dependencies. Add the following line with the other source statements:
source pipelines/utilities/coredns.sh🔗 Analysis chain
Verify CoreDNS scaling dependencies.
The scale_up_coredns function is called here, but we need to ensure it's properly sourced.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check if coredns.sh is properly sourced
# Test: Search for the source statement for coredns.sh
rg -A 2 'source.*coredns.sh' 'pipelines/e2e/scripts/longhorn-setup.sh'
Length of output: 70
Script:
#!/bin/bash
# Let's check for any coredns.sh file in the repository
fd 'coredns.sh'
# Let's also check the content of longhorn-setup.sh to see all source statements
rg 'source' 'pipelines/e2e/scripts/longhorn-setup.sh'
# And check if scale_up_coredns function is defined in the same file
rg -A 5 'scale_up_coredns' 'pipelines/e2e/scripts/longhorn-setup.sh'
Length of output: 936
Script:
#!/bin/bash
# Let's check if coredns.sh is sourced in any other script that's sourced by longhorn-setup.sh
for file in $(rg -l 'source' 'pipelines/e2e/scripts/longhorn-setup.sh' | xargs rg -l 'source.*coredns.sh'); do
echo "Found in: $file"
rg 'source.*coredns.sh' "$file"
done
# Let's also check the content of the coredns.sh file to verify the function exists
rg -A 5 'scale_up_coredns' 'pipelines/utilities/coredns.sh'
Length of output: 267
…by node down test cases Signed-off-by: Yang Chiu <[email protected]>
yangchiu
force-pushed
the
scale-up-coredns
branch
from
95598bb to
044b944
Compare
Which issue(s) this PR fixes:
Issue longhorn/longhorn#9870 longhorn/longhorn#9752
What this PR does / why we need it:
scale up coredns to 3 replicas to prevent it from being affected by node down test cases
Special notes for your reviewer:
Additional documentation or context
Summary by CodeRabbit
New Features
Bug Fixes