Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: upgrade golang version to 1.23 #2176

Merged
merged 2 commits into from
Dec 6, 2024
Merged

ci: upgrade golang version to 1.23 #2176

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef777f7
ci: upgrade golang version to 1.23
yangchiu Dec 4, 2024
64bd250
Merge branch 'master' into update-golang
yangchiu Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test_framework/Dockerfile.setup
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.22-alpine3.19
FROM golang:1.23-alpine3.19

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Critical: Go 1.23 is not yet released

The base image golang:1.23-alpine3.19 references an unreleased version of Go. As of December 2024, Go 1.22 is the latest stable version. Using an unreleased version in a test framework could lead to:

  • Build failures when the image is not found
  • Potential stability issues
  • CI/CD pipeline disruptions

Recommend using the latest stable version instead:

-FROM golang:1.23-alpine3.19
+FROM golang:1.22-alpine3.19
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
FROM golang:1.23-alpine3.19
FROM golang:1.22-alpine3.19

ARG KUBECTL_VERSION=v1.30.0

Expand Down
Loading