-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test_provisioner_generic_ephemeral skeleton #1820
Add test_provisioner_generic_ephemeral skeleton #1820
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b83d897
to
0e50eab
Compare
0e50eab
to
f4b70af
Compare
Fixed the linting issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine as a placeholder. Is there an associated issue to fill it in?
f4b70af
to
a00efab
Compare
It is linked in the issue: longhorn/longhorn#8203. |
- The volume parameters match the StorageClass parameters. | ||
- The volume.status.kubernetesStatus.workloadStatus reflects the | ||
running Pod. | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a test step attempting to write data in ephemeral volume?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It definitely can't hurt, so I added it in an amend. For context, I wrote this skeleton to mirror test_provisioner_mount
(directly above in the file), which does not. Importantly, we cannot follow the pattern of some other tests and read the data back from a different pod, because the life cycle of a generic ephemeral volume mirrors the life cycle of the pod it is created with.
Longhorn 8198 Signed-off-by: Eric Weber <[email protected]>
a00efab
to
566c8ea
Compare
Which issue(s) this PR fixes:
longhorn/longhorn#8198
What this PR does / why we need it:
longhorn/longhorn#8198 uncovered the fact that a change had unknowingly broken Longhorn generic ephemeral volumes. We need an automated test to ensure this can't happen in the future.
Special notes for your reviewer:
I wasn't really sure if this skeleton fit best in
test_provisioner.py
(since we want to test the ability to provision generic ephemeral volumes) ortest_kubernetes.py
, since the actual change I made in longhorn/longhorn-manager#2701 ensuresvolume.status.kubernetesStatus.workloadStatus
was correctly populated by the Longhorn Kuberntes PV controller. I went with my gut, but I'm fine with moving it if QA thinks it makes better sense elsewhere.