-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(integration/manual): support GKE Container-Optimized OS #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c3y1huang
force-pushed
the
feat-support-cos
branch
3 times, most recently
from
March 18, 2024 08:28
33c2079
to
db5c5e8
Compare
c3y1huang
changed the title
test(integration): support GKE container optimized OS
test(integration): support GKE Container-Optimized OS
Mar 18, 2024
c3y1huang
changed the title
test(integration): support GKE Container-Optimized OS
test(integration/manual): support GKE Container-Optimized OS
Mar 19, 2024
c3y1huang
force-pushed
the
feat-support-cos
branch
2 times, most recently
from
March 21, 2024 00:49
c8885ed
to
0511773
Compare
c3y1huang
force-pushed
the
feat-support-cos
branch
4 times, most recently
from
March 25, 2024 01:53
24c3b72
to
c3f3bcc
Compare
Test result for test_replica_auto_balance:
|
longhorn/longhorn-6165 Signed-off-by: Chin-Ya Huang <[email protected]>
longhorn/longhorn-6165 Signed-off-by: Chin-Ya Huang <[email protected]>
c3y1huang
force-pushed
the
feat-support-cos
branch
from
March 29, 2024 00:32
c3f3bcc
to
650fded
Compare
@yangchiu Could you please help with the review? |
yangchiu
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#6165
What this PR does / why we need it:
replica_auto_balance_zone
test cases failed when Kubernetes is running on GKE with COS_CONTAINERD. This is because the node zone label is periodically updated with the actual GCP zone. To address this, implement a workaround by refreshing the zone label with each retry iteration to maintain the expected zone label.Alternative
Skip zone-related tests when the cluster is running on COS.
Special notes for your reviewer:
None
Additional documentation or context
None