test: fix flaky test case test_volume_metrics #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref: 7626 Signed-off-by: Chris <[email protected]>
|
@mergify backport v1.6.x v1.5.x |
✅ Backports have been created
|
This was referenced Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue #7626
What this PR does / why we need it:
Improve the test case stability. The origin code have a chance to get value
0byactual_size = float(volume.controllers[0].actualSize)because timing issue lead the test case fail. Update test code to write fixed data size and verify metriclonghorn_volume_actual_size_byteswith the fixed data size.100 times test result
Special notes for your reviewer:
N/A
Additional documentation or context
N/A