Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky test case test_csi_volumesnapshot_restore_pre_provision_backing_image #1797

Merged
merged 2 commits into from
Mar 1, 2024
Merged

test: fix flaky test case test_csi_volumesnapshot_restore_pre_provision_backing_image #1797

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b77cb9
test: fix flaky test case test_csi_volumesnapshot_restore_pre_provisi…
yangchiu Feb 29, 2024
20c7bb7
Merge branch 'master' into snapshot-delete
yangchiu Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions manager/integration/tests/test_csi_snapshotter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
from common import make_deployment_with_pvc, apps_api # NOQA
from common import check_pvc_in_specific_status # NOQA
from common import wait_for_pvc_phase
from common import RETRY_COMMAND_COUNT
from common import BACKING_IMAGE_QCOW2_URL, BACKING_IMAGE_QCOW2_CHECKSUM
from common import BACKING_IMAGE_RAW_URL, BACKING_IMAGE_RAW_CHECKSUM
from common import BACKING_IMAGE_SOURCE_TYPE_DOWNLOAD, RETRY_COUNTS_SHORT
Expand Down Expand Up @@ -280,7 +279,7 @@ def get_volumesnapshotcontent(volumesnapshot_uid):

def wait_volumesnapshot_deleted(name,
namespace,
retry_counts=RETRY_COMMAND_COUNT,
retry_counts=RETRY_COUNTS,
can_be_deleted=True):
api = get_custom_object_api_client()
api_group = "snapshot.storage.k8s.io"
Expand Down Expand Up @@ -1349,8 +1348,7 @@ def finalizer():
delete_and_wait_pvc(core_api, restore_pvc_name)
delete_volumesnapshot(csivolsnap_name, "default")
wait_volumesnapshot_deleted(csivolsnap_name,
"default",
retry_counts=RETRY_COUNTS_SHORT)
"default")

request.addfinalizer(finalizer)

Expand Down Expand Up @@ -1661,7 +1659,6 @@ def finalizer():
delete_and_wait_pvc(core_api, pvc['metadata']['name'])
delete_volumesnapshot(csivolsnap_name, "default")
wait_volumesnapshot_deleted(csivolsnap_name,
"default",
retry_counts=RETRY_COUNTS_SHORT)
"default")

request.addfinalizer(finalizer)