Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky test case test_replica_rebuild_per_volume_limit #1789

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

roger-ryao
Copy link
Contributor

Which issue(s) this PR fixes:

longhorn/longhorn#8011

What this PR does / why we need it:

https://github.com/longhorn/longhorn-tests/blob/master/manager/integration/tests/test_scheduling.py#L443C8-L443C51

Add wait_for_volume_healthy before deleting replicas to wait for volume rebuilding to complete, and avoid the error failed to remove replica: no other healthy replica available.

Special notes for your reviewer:

Additional documentation or context

https://ci.longhorn.io/job/private/job/longhorn-tests-regression/6439/consoleText

jenkins test result:
https://ci.longhorn.io/job/private/job/longhorn-tests-regression/6442/
Screenshot_20240229_181942

Add wait_for_volume_healthy before deleting replicas

to wait for volume rebuilding to complete.

longhorn/longhorn#8011

Signed-off-by: Roger Yao <[email protected]>
@roger-ryao roger-ryao self-assigned this Feb 29, 2024
@roger-ryao roger-ryao requested a review from a team as a code owner February 29, 2024 10:21
Copy link
Member

@yangchiu yangchiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yangchiu yangchiu merged commit 76f9406 into longhorn:master Feb 29, 2024
5 checks passed
@roger-ryao roger-ryao deleted the issue8011 branch March 1, 2024 00:51
@roger-ryao
Copy link
Contributor Author

@mergify backport v1.6.x v1.5.x

Copy link

mergify bot commented Mar 1, 2024

backport v1.6.x v1.5.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants