Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky test case test_engine_image_daemonset_restart (backport #1736) #1752

Merged
merged 3 commits into from
Feb 23, 2024
Merged

test: fix flaky test case test_engine_image_daemonset_restart (backport #1736) #1752

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3098131
test: fix flaky test case test_engine_image_daemonset_restart
yangchiu Feb 22, 2024
72c5192
Merge branch 'v1.6.x' into mergify/bp/v1.6.x/pr-1736
yangchiu Feb 23, 2024
693c538
Merge branch 'v1.6.x' into mergify/bp/v1.6.x/pr-1736
yangchiu Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions manager/integration/tests/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2211,10 +2211,10 @@ def wait_for_engine_image_condition(client, image_name, state):
# This helps to prevent the flaky test case in which the ENGINE_NAME
# is flapping between ready and not ready a few times before settling
# down to the ready state
# https://github.com/longhorn/longhorn-tests/pull/1638
# https://github.com/longhorn/longhorn/issues/7438
state_count = 1
if state == "True":
state_count = 5
state_count = 60

c = 0
for i in range(RETRY_COUNTS):
Expand Down